Skip to content
This repository was archived by the owner on Sep 30, 2024. It is now read-only.

[Backport 5.1]: remove SendEmail and migrate conf endpoint#55756

Merged
camdencheek merged 5 commits into
5.1from
cc/backport-55648-to-5.1
Aug 17, 2023
Merged

[Backport 5.1]: remove SendEmail and migrate conf endpoint#55756
camdencheek merged 5 commits into
5.1from
cc/backport-55648-to-5.1

Conversation

@camdencheek

@camdencheek camdencheek commented Aug 10, 2023 •
edited
Loading

Copy link
Copy Markdown
Member

This cherry-picks two commits from main.

Manual because of some qdrant-related conflicts

Test plan

Tested in main

@cla-bot cla-bot Bot added the cla-signed label Aug 10, 2023
@camdencheek
Backend: remove internalClient.SendEmail (#55459)
33376ee 
Now that config can be fetched from all services, there is no need for
this internalClient method. One fewer to implement for gRPC

(cherry picked from commit f9d67fe)
@camdencheek
gRPC: migrate conf endpoint (#55648)
99a023e 
(cherry picked from commit 1dd8601)
@camdencheek camdencheek force-pushed the cc/backport-55648-to-5.1 branch from e6177cc to 99a023e Compare August 17, 2023 21:22
@camdencheek camdencheek marked this pull request as ready for review August 17, 2023 21:27
@camdencheek camdencheek requested a review from ggilmore August 17, 2023 21:27
@camdencheek camdencheek force-pushed the cc/backport-55648-to-5.1 branch from 4862d7d to 88b1dca Compare August 17, 2023 21:28
@camdencheek camdencheek enabled auto-merge (squash) August 17, 2023 21:29
@sourcegraph-bot

sourcegraph-bot commented Aug 17, 2023 •
edited
Loading

Copy link
Copy Markdown
Contributor

📖 Storybook live preview

@camdencheek
Backend: remove internalClient.ExternalURL (#55463)
76a1634 
This removes the `internalClient.ExternalURL` method, which can be
replaced with a simple call to `conf.Get()`
@camdencheek
fix imports
6ff7479
@camdencheek camdencheek disabled auto-merge August 17, 2023 22:01
@camdencheek camdencheek enabled auto-merge (squash) August 17, 2023 22:01
@sourcegraph-bot

sourcegraph-bot commented Aug 17, 2023

Copy link
Copy Markdown
Contributor

Codenotify: Notifying subscribers in CODENOTIFY files for diff 3d9e6c7...6ff7479.

Notify File(s)
@eseliger internal/batches/reconciler/BUILD.bazel
internal/batches/reconciler/executor_test.go
internal/batches/reconciler/reconciler_test.go
internal/batches/types/BUILD.bazel
internal/batches/types/batch_change.go
internal/batches/types/batch_change_test.go

@camdencheek camdencheek merged commit 405c6b7 into 5.1 Aug 17, 2023
@camdencheek camdencheek deleted the cc/backport-55648-to-5.1 branch August 17, 2023 22:19
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

1 more reviewer

@ggilmore ggilmore ggilmore approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

cla-signed

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@camdencheek @sourcegraph-bot @ggilmore