Skip to content
This repository was archived by the owner on Sep 30, 2024. It is now read-only.

search contexts: show alert if default is not available#45500

Merged
limitedmage merged 4 commits into
jp/selectdefaultuifrom
jp/nodefaultmessage
Dec 12, 2022
Merged

search contexts: show alert if default is not available#45500
limitedmage merged 4 commits into
jp/selectdefaultuifrom
jp/nodefaultmessage

Conversation

@limitedmage

Copy link
Copy Markdown
Contributor

Stacked on #45489

Part of #44903

image

Test plan

  1. Using an admin user, create a public context on the global namespace
  2. Log into a non-admin user and set that public context as default
  3. Log back into the admin user and make that context private
  4. Log back into the non-admin user and open the context dropdown. The message should now show.

Additionally, this message shouldn't show if a user with a default context runs a search on the menu and the results do not include the default context.

@sourcegraph-bot

sourcegraph-bot commented Dec 9, 2022

Copy link
Copy Markdown
Contributor

Codenotify: Notifying subscribers in CODENOTIFY files for diff c903bc9...0148f2f.

Notify File(s)
@fkling client/search-ui/src/input/SearchContextMenu.tsx
client/search/src/backend.ts

@sg-e2e-regression-test-bob

sg-e2e-regression-test-bob commented Dec 9, 2022

Copy link
Copy Markdown

Bundle size report 📦

Initial size Total size Async size Modules
0.03% (+0.89 kb) 0.03% (+3.87 kb) 0.02% (+2.98 kb) 0.00% (0)

Look at the Statoscope report for a full comparison between the commits 0148f2f and 85243de or learn more.

Open explanation
  • Initial size is the size of the initial bundle (the one that is loaded when you open the page)
  • Total size is the size of the initial bundle + all the async loaded chunks
  • Async size is the size of all the async loaded chunks
  • Modules is the number of modules in the initial bundle

@limitedmage limitedmage merged commit cce3cdc into jp/selectdefaultui Dec 12, 2022
@limitedmage limitedmage deleted the jp/nodefaultmessage branch December 12, 2022 17:18
limitedmage added a commit that referenced this pull request Dec 12, 2022
* search contexts: select default context on page load

* search contexts: show alert if default is not available (#45500)
limitedmage added a commit that referenced this pull request Dec 12, 2022
)

* search contexts: add backend for querying default search context

* search contexts: select default context on page load (#45489)

* search contexts: show alert if default is not available (#45500)
limitedmage added a commit that referenced this pull request Dec 12, 2022
* search contexts: show default context in dropdown

* search contexts: add backend for querying default search context (#45483)

* search contexts: select default context on page load (#45489)

* search contexts: show alert if default is not available (#45500)
limitedmage added a commit that referenced this pull request Dec 12, 2022
…45387)

* search contexts: set default from management page

* search contexts: show default context in dropdown (#45430)

* search contexts: add backend for querying default search context (#45483)

* search contexts: select default context on page load (#45489)

* search contexts: show alert if default is not available (#45500)
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants