Skip to content
This repository was archived by the owner on Sep 30, 2024. It is now read-only.

search contexts: select default context on page load#45489

Merged
limitedmage merged 8 commits into
jp/selectdefaultfrom
jp/selectdefaultui
Dec 12, 2022
Merged

search contexts: select default context on page load#45489
limitedmage merged 8 commits into
jp/selectdefaultfrom
jp/selectdefaultui

Conversation

@limitedmage

@limitedmage limitedmage commented Dec 9, 2022

Copy link
Copy Markdown
Contributor

Stacked on #45483

Part of #44903

Test plan

  • When loading the search homepage from scratch, the default context should be selected, regardless of which context the user selected last
  • When loading the search homepage without a full refresh, the currently selected context should remain selected
  • When loading the search results page, the context in the search query should be selected, if available
  • When loading the search results page from scratch, if the context in the search query is not available, the default context should be selected
  • When loading the search results page without a full refresh, if the context in the search query is not available, the currently-selected context should remain selected
  • When loading the search results page with a query that does not contain a context, the global context should be selected
  • If the user doesn't have a default context, the global context should be used as the default context

@cla-bot cla-bot Bot added the cla-signed label Dec 9, 2022
@limitedmage limitedmage mentioned this pull request Dec 9, 2022
Closed
20 tasks
@sg-e2e-regression-test-bob

sg-e2e-regression-test-bob commented Dec 9, 2022 •
edited
Loading

Copy link
Copy Markdown

Bundle size report 📦

Initial size Total size Async size Modules
0.01% (+0.33 kb) 0.02% (+3.31 kb) 0.02% (+2.98 kb) 0.00% (0)

Look at the Statoscope report for a full comparison between the commits 7b097d1 and 85243de or learn more.

Open explanation
  • Initial size is the size of the initial bundle (the one that is loaded when you open the page)
  • Total size is the size of the initial bundle + all the async loaded chunks
  • Async size is the size of all the async loaded chunks
  • Modules is the number of modules in the initial bundle

@limitedmage limitedmage marked this pull request as ready for review December 9, 2022 22:18
@limitedmage limitedmage requested review from a team, novoselrok and quinnkeast December 9, 2022 22:18
@sourcegraph-bot

sourcegraph-bot commented Dec 9, 2022 •
edited
Loading

Copy link
Copy Markdown
Contributor

Codenotify: Notifying subscribers in CODENOTIFY files for diff 4bf09a0...cce3cdc.

Notify File(s)
@fkling client/search-ui/src/input/SearchContextMenu.tsx
client/search/src/backend.ts
client/search/src/index.ts

@limitedmage limitedmage mentioned this pull request Dec 9, 2022
Merged
@limitedmage
search contexts: show alert if default is not available (#45500)
cce3cdc 
* search contexts: show alert if default is not available

* fix prettier
@limitedmage limitedmage merged commit 3e52ece into jp/selectdefault Dec 12, 2022
@limitedmage limitedmage deleted the jp/selectdefaultui branch December 12, 2022 17:18
limitedmage added a commit that referenced this pull request Dec 12, 2022
@limitedmage
search contexts: add backend for querying default search context (#45483
5253712 
)

* search contexts: add backend for querying default search context

* search contexts: select default context on page load (#45489)

* search contexts: show alert if default is not available (#45500)
limitedmage added a commit that referenced this pull request Dec 12, 2022
@limitedmage
search contexts: show default context in dropdown (#45430)
0edde93 
* search contexts: show default context in dropdown

* search contexts: add backend for querying default search context (#45483)

* search contexts: select default context on page load (#45489)

* search contexts: show alert if default is not available (#45500)
limitedmage added a commit that referenced this pull request Dec 12, 2022
@limitedmage
search contexts: allow setting a default context and use it on load (#…
58f7e59 
…45387)

* search contexts: set default from management page

* search contexts: show default context in dropdown (#45430)

* search contexts: add backend for querying default search context (#45483)

* search contexts: select default context on page load (#45489)

* search contexts: show alert if default is not available (#45500)
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@quinnkeast quinnkeast Awaiting requested review from quinnkeast

1 more reviewer

@novoselrok novoselrok novoselrok approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

cla-signed

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@limitedmage @sg-e2e-regression-test-bob @sourcegraph-bot @novoselrok