Skip to content
This repository was archived by the owner on Sep 30, 2024. It is now read-only.

search contexts: show default context in dropdown#45430

Merged
limitedmage merged 4 commits into
jp/defaultcontextfrom
jp/defaultcontextdropdown
Dec 12, 2022
Merged

search contexts: show default context in dropdown#45430
limitedmage merged 4 commits into
jp/defaultcontextfrom
jp/defaultcontextdropdown

Conversation

@limitedmage

@limitedmage limitedmage commented Dec 8, 2022 •
edited
Loading

Copy link
Copy Markdown
Contributor

Stacked on #45387

Part of #44903

Shows the user's current search context in the search context dropdown with the "default" tag. This also removes the reset button.

image

Test plan

Updated storybook visual tests

App preview:

Check out the client app preview documentation to learn more.

@limitedmage limitedmage requested review from a team and quinnkeast December 8, 2022 18:19
@cla-bot cla-bot Bot added the cla-signed label Dec 8, 2022
@sourcegraph-bot

sourcegraph-bot commented Dec 8, 2022 •
edited
Loading

Copy link
Copy Markdown
Contributor

Codenotify: Notifying subscribers in CODENOTIFY files for diff f02308d...5253712.

Notify File(s)
@beyang internal/search/searchcontexts/search_contexts.go
internal/search/searchcontexts/search_contexts_test.go
@camdencheek internal/search/searchcontexts/search_contexts.go
internal/search/searchcontexts/search_contexts_test.go
@fkling client/search-ui/src/input/SearchBox.story.tsx
client/search-ui/src/input/SearchContextDropdown.test.tsx
client/search-ui/src/input/SearchContextMenu.story.tsx
client/search-ui/src/input/SearchContextMenu.test.tsx
client/search-ui/src/input/SearchContextMenu.tsx
client/search/src/backend.ts
client/search/src/index.ts
client/web/src/search/home/SearchPage.story.tsx
client/web/src/search/home/SearchPage.test.tsx
@keegancsmith cmd/frontend/graphqlbackend/search_contexts.go
internal/search/searchcontexts/search_contexts.go
internal/search/searchcontexts/search_contexts_test.go
@philipp-spiess client/jetbrains/webview/src/search/App.tsx
client/jetbrains/webview/src/search/input/JetBrainsSearchBox.story.tsx
client/jetbrains/webview/src/search/input/JetBrainsSearchBox.tsx
@rvantonder cmd/frontend/graphqlbackend/search_contexts.go
@vdavid client/jetbrains/webview/src/search/App.tsx
client/jetbrains/webview/src/search/input/JetBrainsSearchBox.story.tsx
client/jetbrains/webview/src/search/input/JetBrainsSearchBox.tsx

@sg-e2e-regression-test-bob

sg-e2e-regression-test-bob commented Dec 8, 2022 •
edited
Loading

Copy link
Copy Markdown

Bundle size report 📦

Initial size Total size Async size Modules
-0.02% (-0.51 kb) 0.02% (+2.47 kb) 0.02% (+2.98 kb) 0.00% (0)

Look at the Statoscope report for a full comparison between the commits 2805702 and 85243de or learn more.

Open explanation
  • Initial size is the size of the initial bundle (the one that is loaded when you open the page)
  • Total size is the size of the initial bundle + all the async loaded chunks
  • Async size is the size of all the async loaded chunks
  • Modules is the number of modules in the initial bundle

This was referenced Dec 9, 2022
Closed
Merged
@limitedmage
search contexts: add backend for querying default search context (#45483
5253712 
)

* search contexts: add backend for querying default search context

* search contexts: select default context on page load (#45489)

* search contexts: show alert if default is not available (#45500)
@limitedmage limitedmage merged commit 0edde93 into jp/defaultcontext Dec 12, 2022
@limitedmage limitedmage deleted the jp/defaultcontextdropdown branch December 12, 2022 17:19
limitedmage added a commit that referenced this pull request Dec 12, 2022
@limitedmage
search contexts: allow setting a default context and use it on load (#…
58f7e59 
…45387)

* search contexts: set default from management page

* search contexts: show default context in dropdown (#45430)

* search contexts: add backend for querying default search context (#45483)

* search contexts: select default context on page load (#45489)

* search contexts: show alert if default is not available (#45500)
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@quinnkeast quinnkeast Awaiting requested review from quinnkeast

1 more reviewer

@novoselrok novoselrok novoselrok approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

cla-signed

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@limitedmage @sourcegraph-bot @sg-e2e-regression-test-bob @novoselrok