Skip to content
This repository was archived by the owner on Sep 30, 2024. It is now read-only.

search contexts: permanently enable management page#45302

Merged
limitedmage merged 3 commits into
jp/starredcontextsmenufrom
jp/enablecontextmanagement
Dec 7, 2022
Merged

search contexts: permanently enable management page#45302
limitedmage merged 3 commits into
jp/starredcontextsmenufrom
jp/enablecontextmanagement

Conversation

@limitedmage

@limitedmage limitedmage commented Dec 6, 2022

Copy link
Copy Markdown
Contributor

Stacked on #45289

Part of #44903

The experimental setting showSearchContextManagement should now be permanently enabled. This way, all users with access to search contexts can access the management page to star contexts/set as default.

The experimental setting showSearchContext is still required to be enabled for contexts to be shown (this is on by default).

Test plan

All existing tests should continue passing

@limitedmage limitedmage requested review from a team, novoselrok and quinnkeast December 6, 2022 22:28
@cla-bot cla-bot Bot added the cla-signed label Dec 6, 2022
@limitedmage limitedmage mentioned this pull request Dec 6, 2022
Closed
20 tasks
@sourcegraph-bot

sourcegraph-bot commented Dec 6, 2022 •
edited
Loading

Copy link
Copy Markdown
Contributor

Codenotify: Notifying subscribers in CODENOTIFY files for diff 904bf84...dc3a3fe.

Notify File(s)
@fkling client/web/src/search/home/SearchPageInput.tsx
client/web/src/search/input/SearchNavbarItem.tsx
@rvantonder doc/code_search/explanations/features.md
doc/code_search/how-to/create_search_context_graphql.md
@sourcegraph/delivery doc/admin/how-to/converting-version-contexts-to-search-contexts.md

@sg-e2e-regression-test-bob

sg-e2e-regression-test-bob commented Dec 6, 2022 •
edited
Loading

Copy link
Copy Markdown

Bundle size report 📦

Initial size Total size Async size Modules
0.02% (+0.45 kb) 0.04% (+5.67 kb) 0.04% (+5.21 kb) 0.00% (0)

Look at the Statoscope report for a full comparison between the commits dc3a3fe and cbecc53 or learn more.

Open explanation
  • Initial size is the size of the initial bundle (the one that is loaded when you open the page)
  • Total size is the size of the initial bundle + all the async loaded chunks
  • Async size is the size of all the async loaded chunks
  • Modules is the number of modules in the initial bundle

@quinnkeast

quinnkeast commented Dec 7, 2022

Copy link
Copy Markdown
Contributor

The experimental setting showSearchContext is still required to be enabled for contexts to be shown (this is on by default).

At what point would we no longer consider this an experimental setting?

@limitedmage

limitedmage commented Dec 7, 2022

Copy link
Copy Markdown
Contributor Author

The experimental setting showSearchContext is still required to be enabled for contexts to be shown (this is on by default).

At what point would we no longer consider this an experimental setting?

We don't really have any guidelines on the lifetime of experimental features, this is honestly something we should be better about. The main reason we decide to remove an experimental setting is when there's tech debt related to supporting having the feature disable-able. Right now, there's no cost to keeping search contexts as a setting because search contexts need to be disable-able anyway since they're not supported in the OSS build.

@limitedmage limitedmage merged commit 8f46498 into jp/starredcontextsmenu Dec 7, 2022
@limitedmage limitedmage deleted the jp/enablecontextmanagement branch December 7, 2022 16:05
limitedmage added a commit that referenced this pull request Dec 7, 2022
@limitedmage
search contexts: show stars in search context dropdown menu (#45289)
d03e7a3 
* search contexts: show stars in search context dropdown menu

* update changelog

* search contexts: permanently enable management page (#45302)

* search contexts: permanently enable management page

* update docs

* fix lint
limitedmage added a commit that referenced this pull request Dec 7, 2022
@limitedmage
search contexts: allow starring from the individual context page (#45281
539ad6b 
)

* search contexts: allow starring from the individual context page

* search contexts: show stars in search context dropdown menu (#45289)

* search contexts: permanently enable management page (#45302)
limitedmage added a commit that referenced this pull request Dec 7, 2022
@limitedmage
search contexts: add support for starring and unstarring contexts (#4…
1c284d9 
…5230)

* search contexts: add/remove star via management page

* search contexts: allow starring from the individual context page (#45281)

* search contexts: show stars in search context dropdown menu (#45289)

* search contexts: permanently enable management page (#45302)
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

2 more reviewers

@quinnkeast quinnkeast quinnkeast approved these changes

@novoselrok novoselrok novoselrok approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

cla-signed

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@limitedmage @sourcegraph-bot @sg-e2e-regression-test-bob @quinnkeast @novoselrok