Skip to content
This repository was archived by the owner on Sep 30, 2024. It is now read-only.

search contexts: show stars in search context dropdown menu#45289

Merged
limitedmage merged 4 commits into
jp/starcontextpagefrom
jp/starredcontextsmenu
Dec 7, 2022
Merged

search contexts: show stars in search context dropdown menu#45289
limitedmage merged 4 commits into
jp/starcontextpagefrom
jp/starredcontextsmenu

Conversation

@limitedmage

@limitedmage limitedmage commented Dec 6, 2022

Copy link
Copy Markdown
Contributor

Stacked on #45281

Part of #44903

Shows stars in the search context menu next to the search box. Shows a divider between starred and unstarred items.

image

Test plan

Update storybook tests

@limitedmage limitedmage requested review from a team, novoselrok and quinnkeast December 6, 2022 19:36
@cla-bot cla-bot Bot added the cla-signed label Dec 6, 2022
@limitedmage limitedmage mentioned this pull request Dec 6, 2022
Closed
20 tasks
@sourcegraph-bot

sourcegraph-bot commented Dec 6, 2022 •
edited
Loading

Copy link
Copy Markdown
Contributor

Codenotify: Notifying subscribers in CODENOTIFY files for diff 9e20f16...8f46498.

Notify File(s)
@fkling client/search-ui/src/input/SearchContextMenu.module.scss
client/search-ui/src/input/SearchContextMenu.story.tsx
client/search-ui/src/input/SearchContextMenu.tsx
client/search-ui/src/input/SearchContextMenuItem.story.tsx
client/web/src/search/home/SearchPageInput.tsx
client/web/src/search/input/SearchNavbarItem.tsx
@rvantonder doc/code_search/explanations/features.md
doc/code_search/how-to/create_search_context_graphql.md
@sourcegraph/delivery doc/admin/how-to/converting-version-contexts-to-search-contexts.md

@sg-e2e-regression-test-bob

sg-e2e-regression-test-bob commented Dec 6, 2022 •
edited
Loading

Copy link
Copy Markdown

Bundle size report 📦

Initial size Total size Async size Modules
0.02% (+0.59 kb) 0.04% (+6.32 kb) 0.05% (+5.73 kb) 0.00% (0)

Look at the Statoscope report for a full comparison between the commits 904bf84 and cbecc53 or learn more.

Open explanation
  • Initial size is the size of the initial bundle (the one that is loaded when you open the page)
  • Total size is the size of the initial bundle + all the async loaded chunks
  • Async size is the size of all the async loaded chunks
  • Modules is the number of modules in the initial bundle

@limitedmage limitedmage mentioned this pull request Dec 6, 2022
Merged
@limitedmage
search contexts: permanently enable management page (#45302)
8f46498 
* search contexts: permanently enable management page

* update docs

* fix lint
@limitedmage limitedmage merged commit d03e7a3 into jp/starcontextpage Dec 7, 2022
@limitedmage limitedmage deleted the jp/starredcontextsmenu branch December 7, 2022 16:05
limitedmage added a commit that referenced this pull request Dec 7, 2022
@limitedmage
search contexts: allow starring from the individual context page (#45281
539ad6b 
)

* search contexts: allow starring from the individual context page

* search contexts: show stars in search context dropdown menu (#45289)

* search contexts: permanently enable management page (#45302)
limitedmage added a commit that referenced this pull request Dec 7, 2022
@limitedmage
search contexts: add support for starring and unstarring contexts (#4…
1c284d9 
…5230)

* search contexts: add/remove star via management page

* search contexts: allow starring from the individual context page (#45281)

* search contexts: show stars in search context dropdown menu (#45289)

* search contexts: permanently enable management page (#45302)
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

2 more reviewers

@quinnkeast quinnkeast quinnkeast approved these changes

@novoselrok novoselrok novoselrok approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

cla-signed

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@limitedmage @sourcegraph-bot @sg-e2e-regression-test-bob @quinnkeast @novoselrok