Skip to content
This repository was archived by the owner on Sep 30, 2024. It is now read-only.

search contexts: allow starring from the individual context page#45281

Merged
limitedmage merged 4 commits into
jp/starcontextsfrom
jp/starcontextpage
Dec 7, 2022
Merged

search contexts: allow starring from the individual context page#45281
limitedmage merged 4 commits into
jp/starcontextsfrom
jp/starcontextpage

Conversation

@limitedmage

@limitedmage limitedmage commented Dec 6, 2022

Copy link
Copy Markdown
Contributor

Stacked on #45230

Part of #44903

  • Adds a star button to the individual search context page.
  • Polishes how errors are handled to reduce code duplication between the search context list page and the individual context page.
  • Cleans up spacing in the individual search context page so that contexts without description and/or repos don't have odd unbalanced spacing.

image

image

Test plan

Add new storybook tests, manually verify.

@limitedmage limitedmage requested review from a team, novoselrok and quinnkeast December 6, 2022 18:15
@cla-bot cla-bot Bot added the cla-signed label Dec 6, 2022
@sg-e2e-regression-test-bob

sg-e2e-regression-test-bob commented Dec 6, 2022 •
edited
Loading

Copy link
Copy Markdown

Bundle size report 📦

Initial size Total size Async size Modules
0.00% (0.00 kb) 0.04% (+5.78 kb) 0.05% (+5.78 kb) 0.00% (0)

Look at the Statoscope report for a full comparison between the commits 9e20f16 and cbecc53 or learn more.

Open explanation
  • Initial size is the size of the initial bundle (the one that is loaded when you open the page)
  • Total size is the size of the initial bundle + all the async loaded chunks
  • Async size is the size of all the async loaded chunks
  • Modules is the number of modules in the initial bundle

@sourcegraph-bot

sourcegraph-bot commented Dec 6, 2022 •
edited
Loading

Copy link
Copy Markdown
Contributor

Codenotify: Notifying subscribers in CODENOTIFY files for diff e89721e...d03e7a3.

Notify File(s)
@fkling client/search-ui/src/input/SearchContextDropdown.test.tsx
client/search-ui/src/input/SearchContextMenu.module.scss
client/search-ui/src/input/SearchContextMenu.story.tsx
client/search-ui/src/input/SearchContextMenu.tsx
client/search-ui/src/input/SearchContextMenuItem.story.tsx
client/web/src/search/home/SearchPageInput.tsx
client/web/src/search/input/SearchNavbarItem.tsx
@rvantonder doc/code_search/explanations/features.md
doc/code_search/how-to/create_search_context_graphql.md
@sourcegraph/delivery doc/admin/how-to/converting-version-contexts-to-search-contexts.md

This was referenced Dec 6, 2022
Merged
Closed
@limitedmage
search contexts: show stars in search context dropdown menu (#45289)
d03e7a3 
* search contexts: show stars in search context dropdown menu

* update changelog

* search contexts: permanently enable management page (#45302)

* search contexts: permanently enable management page

* update docs

* fix lint
@limitedmage limitedmage merged commit 539ad6b into jp/starcontexts Dec 7, 2022
@limitedmage limitedmage deleted the jp/starcontextpage branch December 7, 2022 16:06
limitedmage added a commit that referenced this pull request Dec 7, 2022
@limitedmage
search contexts: add support for starring and unstarring contexts (#4…
1c284d9 
…5230)

* search contexts: add/remove star via management page

* search contexts: allow starring from the individual context page (#45281)

* search contexts: show stars in search context dropdown menu (#45289)

* search contexts: permanently enable management page (#45302)
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

2 more reviewers

@quinnkeast quinnkeast quinnkeast approved these changes

@novoselrok novoselrok novoselrok approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

cla-signed

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@limitedmage @sg-e2e-regression-test-bob @sourcegraph-bot @quinnkeast @novoselrok