[test] Add lacp fallback test cases#379
Closed
hzheng5 wants to merge 0 commit intosonic-net:masterfrom
Closed
Conversation
Contributor
Author
|
@rodnymolina Could you please help review the test plan? Thanks, |
Contributor
|
can you add to REAME.test.md for how to run the test? |
Contributor
Author
|
@lguohan Thanks for the reminder. Just added the instruction to REAME.test.md. This test case will run as part of the LAG-2 test cases on t0 topo. Thanks, |
23b9598 to
f3c3d64
Compare
Contributor
|
Can you please resolve the conflict? |
ansible/templates/topo/t0.j2
Outdated
Contributor
There was a problem hiding this comment.
Fallback is enabled only when we have odd index?
Can you please comment what is this like do?
Contributor
Author
There was a problem hiding this comment.
yes. only enable fallback on odd ports here, so we can compare the status between odd ports and even ports to make sure both are in expected state.
Thanks for the suggestion. Will add some comment here.
ansible/README.test.md
Outdated
Contributor
There was a problem hiding this comment.
You need to convert your test into new format
ansible-playbook test_sonic.yml -i str --limit str-s6100-acs-1 --vault-password-file password.txt -e testcase_name=lag-2 -e testbed_name=vms3-t0-s6100
Please check how the recently added tests are executed. Please let me know if you have questions.
Contributor
Author
There was a problem hiding this comment.
sure. Thanks @pavel-shirshov
will rewrite the test case
a451dd9 to
2f2f25b
Compare
Contributor
Author
|
@pavel-shirshov I closed this pull request since the code is too old and has some conflicts. Please review the latest pull request #1187 instead, thanks |
sdszhang
pushed a commit
to sdszhang/sonic-mgmt
that referenced
this pull request
Jun 14, 2025
…only (sonic-net#379) <!-- Please make sure you've read and understood our contributing guidelines; https://github.com/sonic-net/SONiC/blob/gh-pages/CONTRIBUTING.md Please provide following information to help code review process a bit easier: --> ### Description of PR <!-- - Please include a summary of the change and which issue is fixed. - Please also include relevant motivation and context. Where should reviewer start? background context? - List any dependencies that are required for this change. --> Summary: After the change in : sonic-net#17943, default route will advertised from T0 peer in t1-isolated-d56u2 or t1-isolated-d56u1-lag topo. and caused multiple failures in test_acl, as both T0 and T2 are advertising default route. This PR will limit the default route advertisement to -d128 topology only. ### Type of change <!-- - Fill x for your type of change. - e.g. - [x] Bug fix --> - [ ] Bug fix - [ ] Testbed and Framework(new/improvement) - [ ] New Test case - [ ] Skipped for non-supported platforms - [ ] Test case improvement ### Back port request - [ ] 202205 - [ ] 202305 - [ ] 202311 - [ ] 202405 - [ ] 202411 - [x] 202505 ### Approach #### What is the motivation for this PR? Fix failures in test_acl due to the route advertisement change. #### How did you do it? #### How did you verify/test it? acl/test_acl.py::TestBasicAcl::test_ingress_unmatched_blocked[ipv4-ingress-downlink->uplink-default-no_vlan] PASSED [ 0%] acl/test_acl.py::TestBasicAcl::test_egress_unmatched_forwarded[ipv4-ingress-downlink->uplink-default-no_vlan] SKIPPED [ 0%] acl/test_acl.py::TestBasicAcl::test_source_ip_match_forwarded[ipv4-ingress-downlink->uplink-default-no_vlan] PASSED [ 0%] acl/test_acl.py::TestBasicAcl::test_rules_priority_forwarded[ipv4-ingress-downlink->uplink-default-no_vlan] PASSED [ 0%] acl/test_acl.py::TestBasicAcl::test_rules_priority_dropped[ipv4-ingress-downlink->uplink-default-no_vlan] PASSED [ 0%] acl/test_acl.py::TestBasicAcl::test_dest_ip_match_forwarded[ipv4-ingress-downlink->uplink-default-no_vlan] PASSED [ 0%] acl/test_acl.py::TestBasicAcl::test_dest_ip_match_dropped[ipv4-ingress-downlink->uplink-default-no_vlan] PASSED [ 0%] acl/test_acl.py::TestBasicAcl::test_source_ip_match_dropped[ipv4-ingress-downlink->uplink-default-no_vlan] PASSED [ 1%] acl/test_acl.py::TestBasicAcl::test_udp_source_ip_match_forwarded[ipv4-ingress-downlink->uplink-default-no_vlan] PASSED [ 1%] acl/test_acl.py::TestBasicAcl::test_udp_source_ip_match_dropped[ipv4-ingress-downlink->uplink-default-no_vlan] PASSED [ 1%] acl/test_acl.py::TestBasicAcl::test_icmp_source_ip_match_dropped[ipv4-ingress-downlink->uplink-default-no_vlan] PASSED [ 1%] ...... ========= 768 passed, 32 skipped, 2690 warnings in 8803.15s (2:26:43) ========== #### Any platform specific information? #### Supported testbed topology if it's a new test case? ### Documentation <!-- (If it's a new feature, new test case) Did you update documentation/Wiki relevant to your implementation? Link to the wiki page? -->
kazinator-arista
pushed a commit
to kazinator-arista/sonic-mgmt
that referenced
this pull request
Mar 4, 2026
…5369) * [201811][swss-common] advance swss-common sub module head - Fix SubscriberStateTable::hasCachedData formula for a timing risk (sonic-net#379) Signed-off-by: Ying Xie <ying.xie@microsoft.com> * Fix build of the unit test of SubscriberStateTable (sonic-net#383)
kazinator-arista
pushed a commit
to kazinator-arista/sonic-mgmt
that referenced
this pull request
Mar 4, 2026
Fix SubscriberStateTable::hasCachedData formula for a timing risk (sonic-net#379) Add restapi DB (sonic-net#386) Fix swss::exec return value (sonic-net#368) Signed-off-by: Abhishek Dosi <abdosi@microsoft.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Please note min_port and fallback configure are mutual exclusive
for each lag.
Depends on sonic-net/sonic-buildimage#1118
Signed-off-by: Haiyang Zheng haiyang.z@alibaba-inc.com
Description of PR
Fixes # (issue)
Type of change
Approach
How did you do it?
How did you verify/test it?
Any platform specific information?
Supported testbed topology if it's a new test case?
Documentation