Skip to content

[everflow] update old script to fit configDB#383

Closed
okanchou9 wants to merge 2 commits intosonic-net:masterfrom
okanchou9:everflow_update
Closed

[everflow] update old script to fit configDB#383
okanchou9 wants to merge 2 commits intosonic-net:masterfrom
okanchou9:everflow_update

Conversation

@okanchou9
Copy link
Copy Markdown
Contributor

Description of PR

Since we are using configDB to setup the configuration of everflow in latest build of SONiC, just modify the script to use mirror_session.py for everflow session setup.

Type of change

  • Discard the old configuration method(swssconfig xxx.json) and use mirror_session.py to create/delete mirror session.
  • Modify the test case "Config tests - valid config (all integers are in hex)" from positive test to negative test due to configDB behavior(configDB will reject multiple mirror sessions which have the same session name).

Approach

How did you do it?

  • Just modify script to fit the configure style of configDB.

How did you verify/test it?

  • Run the modified script on my DUT without any issue. Please refer Test_log for detail info.

Any platform specific information?

  • I'm using INGRASYS-S9100-C32 as DUT.

Supported testbed topology if it's a new test case?

  • As the original script, only PTF32 is the supported testbed topology.

Documentation

  • There is no test plan for this script, at least I cannot find it. Does anyone has it?

Signed-off-by: okanchou9 <kenie7@gmail.com>
set_fact:
testname: config_test
config_files:
- config_src_ip_invalid_1.json
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

since these files are no longer used, can you remove them?

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@lguohan
Just removed those useless from branch.

@okanchou9 okanchou9 requested a review from a team as a code owner March 2, 2022 17:37
@wangxin
Copy link
Copy Markdown
Collaborator

wangxin commented Apr 17, 2024

Hi @okanchou9 , this PR is to add ansible playbook based testing. If this test is still required, probably you can try to add a pytest based script. I am closing this PR for now.

@wangxin wangxin closed this Apr 17, 2024
sdszhang pushed a commit to sdszhang/sonic-mgmt that referenced this pull request Jun 14, 2025
… peers (sonic-net#383)

<!--
Please make sure you've read and understood our contributing guidelines;
https://github.com/sonic-net/SONiC/blob/gh-pages/CONTRIBUTING.md

Please provide following information to help code review process a bit easier:
-->
### Description of PR
<!--
- Please include a summary of the change and which issue is fixed.
- Please also include relevant motivation and context. Where should reviewer start? background context?
- List any dependencies that are required for this change.
-->

Summary:
Fixes # (issue)
Depending on the version of cEOSLab being run, the docker peer devices to the SONiC DUT may be running in "multi-agent" mode. This means that the agent referred to as "bgpd" in testing may differ based on the mode. When running in "multi-agent" mode, the "Bgp" agent needs to be stopped, instead of "Rib". The mode is determined based on the output of a CLI show-command run on the cEOSLab docker peer.

### Type of change

<!--
- Fill x for your type of change.
- e.g.
- [x] Bug fix
-->

- [ ] Bug fix
- [ ] Testbed and Framework(new/improvement)
- [ ] New Test case
 - [ ] Skipped for non-supported platforms
- [x] Test case improvement

### Back port request
- [ ] 202012
- [ ] 202205
- [ ] 202305
- [ ] 202311
- [ ] 202405
- [ ] 202411

### Approach
#### What is the motivation for this PR?
Addressing this bug means that the test bgp/test_bgp_gr_helper.py will restart the correct "bgpd" agent and pass irrespective of the version of cEOSLab being run on the docker peers.

#### How did you do it?
The test runs the command "show ip route summary | json" on the cEOSLab peer instance and parses the output to identify whether or not the instance is running in "multi-agent" mode. This information is then used to start/stop either the "Bgp" or "Rib" processes.

#### How did you verify/test it?
Verified by running the same bgp/test_bgp_gr_helper.py with and without the fix. With the fix the correct "bgpd" agent is restarted by the test.

#### Any platform specific information?
None.

#### Supported testbed topology if it's a new test case?
No new test case.

### Documentation
<!--
(If it's a new feature, new test case)
Did you update documentation/Wiki relevant to your implementation?
Link to the wiki page?
-->
kazinator-arista pushed a commit to kazinator-arista/sonic-mgmt that referenced this pull request Mar 4, 2026
…5369)

* [201811][swss-common] advance swss-common sub module head

- Fix SubscriberStateTable::hasCachedData formula for a timing risk (sonic-net#379)

Signed-off-by: Ying Xie <ying.xie@microsoft.com>

* Fix build of the unit test of SubscriberStateTable (sonic-net#383)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants