[test] Add lacp fallback test cases#1187
Conversation
Signed-off-by: Haiyang Zheng <haiyang.z@alibaba-inc.com>
Signed-off-by: Haiyang Zheng <haiyang.z@alibaba-inc.com>
|
I'll double review it in a day. Sorry for delay. I want to be sure it is safe with old tests. |
sure. no problem. thanks~ |
| include: single_lag_test.yml | ||
| with_items: lag_facts.names | ||
| when: test_minlink|bool == true | ||
| when: lag_facts.lags[item]['po_config']['runner']['min_ports'] is defined |
There was a problem hiding this comment.
I think you should keep the test_minlink here. The test could be disabled when test_minlink is equal to false.
There was a problem hiding this comment.
OK. got your point. have reverted this change caused by merge. Thanks
| include: single_lag_lacp_rate_test.yml | ||
| with_items: lag_facts.names | ||
| when: test_rate|bool == true No newline at end of file | ||
| when: lag_facts.lags[item]['po_config']['runner']['min_ports'] is defined |
There was a problem hiding this comment.
The same here for test_rate.
Please fix it and I'll merge
There was a problem hiding this comment.
lag_facts.lags[item]['po_config']['runner']['min_ports'] is defined and test_minlink|bool == true
Signed-off-by: Haiyang Zheng <haiyang.z@alibaba-inc.com>
2e15266 to
bdf99e1
Compare
|
Hi @hzheng5 |
Signed-off-by: Haiyang Zheng haiyang.z@alibaba-inc.com
Description of PR
Summary:
Please note min_port and fallback configure are mutual exclusive for each lag.
Type of change
Approach
How did you do it?
The lag_fallback test cases flap the link from VM side while keeping the physical link up, this is to simulate the situation where the remote end stops sending LACP DU. If fallback is enabled, the port should still be selected, and LAG should be kept up. Otherwise, the member port should be unselected, and LAG should be brought down.
How did you verify/test it?
ansible-playbook test_sonic.yml -i {INVENTORY} --limit {DUT_NAME} -e testcase_name=lag_2 -e testbed_name={TESTBED_NAME}
Any platform specific information?
no
Supported testbed topology if it's a new test case?
t0 topo
Documentation
https://github.com/Azure/SONiC/blob/master/doc/lag/LACP%20Fallback%20Feature%20for%20SONiC_v0.5.md