Updates to LLDP Pytest to support multi-asic#2269
Merged
daall merged 9 commits intosonic-net:masterfrom Dec 9, 2020
Merged
Conversation
a) Moved LLDP test case from using minigraph fact to config fact b) Moved LLDP from using Standard lldp fact Ansible Module to user define LLDP Fact module. This user define module is needed since for for Multi-asic platfrom we will have to gather fact from multiple lldp namespace instance. Signed-off-by: Abhishek Dosi <abdosi@micrsoft.com>
daall
suggested changes
Sep 25, 2020
Co-authored-by: Danny Allen <daall@microsoft.com>
Co-authored-by: Danny Allen <daall@microsoft.com>
Co-authored-by: Danny Allen <daall@microsoft.com>
Co-authored-by: Danny Allen <daall@microsoft.com>
Co-authored-by: Danny Allen <daall@microsoft.com>
Signed-off-by: Abhishek Dosi <abdosi@micrsoft.com>
Signed-off-by: Abhishek Dosi <abdosi@micrsoft.com>
Contributor
Author
Contributor
Author
|
@daall can you please review |
daall
approved these changes
Dec 9, 2020
antoninamelnyk
pushed a commit
to antoninamelnyk/sonic-mgmt
that referenced
this pull request
Dec 11, 2020
…2269) Made the following changes to LLDP pytest: a) Moved LLDP test case from using minigraph fact to config fact b) Moved LLDP from using standard LLDP fact ansible module to user-defined LLDP fact module. This user-defined module is needed because we will have to gather facts from multiple LLDP namespace instances for multi-asic platform Signed-off-by: Abhishek Dosi <abdosi@micrsoft.com> Co-authored-by: Danny Allen <daall@microsoft.com>
antoninamelnyk
added a commit
to antoninamelnyk/sonic-mgmt
that referenced
this pull request
Dec 11, 2020
…nic-net#2269)" This reverts commit edd86fe.
abdosi
added a commit
that referenced
this pull request
Mar 24, 2021
vmittal-msft
pushed a commit
to vmittal-msft/sonic-mgmt
that referenced
this pull request
Sep 28, 2021
This PR is continuation of sonic-net#2269 where infra changes were done to support multi-asic platforms. In this PR:- Fix Issue done in sonic-net#2269 where asic_id is 0. LLDP test is enhanced to run on multi-asic devices.
kazinator-arista
pushed a commit
to kazinator-arista/sonic-mgmt
that referenced
this pull request
Mar 4, 2026
Update sonic-utilities submodule pointer to include the following: * Fix test for pfcwd_sw_enable in db_migrator_test ([sonic-net#2252](sonic-net/sonic-utilities#2252)) * [DHCPv6] [202012] Update the dhcpv6_relay config/show cli ([sonic-net#2271](sonic-net/sonic-utilities#2271)) * [vnet_route_check] Align DB data parse logic with format used by swsscommon API ([sonic-net#2268](sonic-net/sonic-utilities#2268)) * [202012] [generate_dump] allow to extend dump with plugin scripts ([sonic-net#2269](sonic-net/sonic-utilities#2269)) Signed-off-by: dprital <drorp@nvidia.com>
kazinator-arista
pushed a commit
to kazinator-arista/sonic-mgmt
that referenced
this pull request
Mar 4, 2026
sonic-swss 25fe915 [crmorch] Prevent exceededLogCounter from resetting when low and high values are equal (sonic-net#2327) 1c3c5e0 [BFD]Retry create BFD with different source UDP port on failure (sonic-net#2225) d5775b1 Skip consistent fail tests (sonic-net#2269) sonicutilities 5800b73 Fix header for the output table following 'show ipv6 interface' command (sonic-net#2219)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What/Why I did:
Updates to LLDP Pytest to support multi-asic following changes are done:
a) Moved LLDP test case from using minigraph fact to config fact. It is generic change
b) Moved LLDP from using Standard lldp fact Ansible Module to
user define LLDP Fact module (open-source code has been reused from standard ansible library). This user define module is needed
since for for Multi-asic platfrom we will have to gather fact from
multiple lldp namespace instance.
How I verify:
Verified LLDP on single-asic platforms.