Enhance LLDP test case for multi-asic platforms#3137
Merged
abdosi merged 19 commits intosonic-net:masterfrom Mar 24, 2021
Merged
Enhance LLDP test case for multi-asic platforms#3137abdosi merged 19 commits intosonic-net:masterfrom
abdosi merged 19 commits intosonic-net:masterfrom
Conversation
Signed-off-by: Abhishek Dosi <abdosi@microsoft.com>
Signed-off-by: Abhishek Dosi <abdosi@microsoft.com>
Signed-off-by: Abhishek Dosi <abdosi@microsoft.com>
Signed-off-by: Abhishek Dosi <abdosi@microsoft.com>
Signed-off-by: Abhishek Dosi <abdosi@microsoft.com>
Signed-off-by: Abhishek Dosi <abdosi@microsoft.com>
Contributor
Author
|
@arlakshm can you please help to review this. |
arlakshm
reviewed
Mar 17, 2021
tests/lldp/test_lldp.py
Outdated
| lldpctl_facts = duthost.lldpctl_facts(skip_interface_pattern_list=["eth0"])['ansible_facts'] | ||
|
|
||
| namespace = duthost.get_namespace_from_asic_id(enum_frontend_asic_index) | ||
| config_facts = duthost.config_facts(host=duthost.hostname, source="running",namespace=namespace)['ansible_facts'] |
Contributor
There was a problem hiding this comment.
can we use the sonicasic.config_facts here ?
Signed-off-by: Abhishek Dosi <abdosi@microsoft.com>
arlakshm
approved these changes
Mar 18, 2021
Contributor
Author
|
/Azurepipelines run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
vmittal-msft
pushed a commit
to vmittal-msft/sonic-mgmt
that referenced
this pull request
Sep 28, 2021
This PR is continuation of sonic-net#2269 where infra changes were done to support multi-asic platforms. In this PR:- Fix Issue done in sonic-net#2269 where asic_id is 0. LLDP test is enhanced to run on multi-asic devices.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What I did:
This PR is continuation of #2269 where infra changes were done to support multi-asic platforms. In this PR:-
Fix Issue done in Updates to LLDP Pytest to support multi-asic #2269 where
asic_idis 0.LLDP test is enhanced to run on multi-asic devices.
How I verify:
Verify on both single and multi-asic platforms.