Skip to content

[reporting] Add DB connector and report uploader script for kusto#2225

Merged
daall merged 3 commits intosonic-net:masterfrom
daall:db_connector
Sep 18, 2020
Merged

[reporting] Add DB connector and report uploader script for kusto#2225
daall merged 3 commits intosonic-net:masterfrom
daall:db_connector

Conversation

@daall
Copy link
Copy Markdown
Contributor

@daall daall commented Sep 16, 2020

Signed-off-by: Danny Allen daall@microsoft.com

Description of PR

Summary: [reporting] Add DB connector and report uploader script for kusto
Fixes # (issue)

Type of change

  • Bug fix
  • Testbed and Framework(new/improvement)
  • Test case(new/improvement)

Approach

What is the motivation for this PR?

We want to upload test results to a database so we can store them long-term, query them, and generate reports. To do so, we need some sort of wrapper so the upload can be automated.

How did you do it?

I added two things:

  1. A "ReportDBConnector" abstraction. Right now there is only a Kusto implementation, but this could be implemented for other databases as well.
  2. A script that uses the Kusto implementation to upload results from a directory.

How did you verify/test it?

Ran locally with some recent test results.

Any platform specific information?

N/A

Supported testbed topology if it's a new test case?

N/A

Documentation

I need to add a detailed README with information regarding the DBConnector design as well as the Kusto design/schema. This will be added in a follow-on PR.

Signed-off-by: Danny Allen <daall@microsoft.com>
@daall daall requested review from a team and lguohan September 16, 2020 18:41
@lgtm-com
Copy link
Copy Markdown

lgtm-com Bot commented Sep 16, 2020

This pull request introduces 5 alerts when merging 3c1a827 into e01b6be - view on LGTM.com

new alerts:

  • 3 for Module is imported more than once
  • 1 for Comparison using is when operands support __eq__
  • 1 for Module is imported with 'import' and 'import from'

Comment thread test_reporting/report_data_storage.py Outdated
Copy link
Copy Markdown
Collaborator

@yxieca yxieca left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved with an minor suggestion.

@lgtm-com
Copy link
Copy Markdown

lgtm-com Bot commented Sep 18, 2020

This pull request introduces 5 alerts when merging cea55f9 into db4b24f - view on LGTM.com

new alerts:

  • 3 for Module is imported more than once
  • 1 for Comparison using is when operands support __eq__
  • 1 for Module is imported with 'import' and 'import from'

@daall
Copy link
Copy Markdown
Contributor Author

daall commented Sep 18, 2020

retest vsimage please

@daall daall merged commit 89e0614 into sonic-net:master Sep 18, 2020
@daall daall deleted the db_connector branch September 18, 2020 20:40
kazinator-arista pushed a commit to kazinator-arista/sonic-mgmt that referenced this pull request Mar 4, 2026
sonic-swss

25fe915 [crmorch] Prevent exceededLogCounter from resetting when low and high values are equal (sonic-net#2327)
1c3c5e0 [BFD]Retry create BFD with different source UDP port on failure (sonic-net#2225)
d5775b1 Skip consistent fail tests (sonic-net#2269)

sonicutilities

5800b73 Fix header for the output table following 'show ipv6 interface' command (sonic-net#2219)
kazinator-arista pushed a commit to kazinator-arista/sonic-mgmt that referenced this pull request Mar 4, 2026
update sonic-utilities submodule

8ac2810 [202111] [generate dump] Move the Core/Log collection to the End of process Execution and removed default timeout  (sonic-net#2225)
77891de [202111] Fix UT failed cause by change pycommon to use swsscommon (sonic-net#2085) (sonic-net#2231)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants