Skip to content

[pytest] Convert Ansible Advanced Reboot fast/warm reboot test cases#1500

Merged
tahmed-dev merged 2 commits intosonic-net:masterfrom
tahmed-dev:taahme/convert-ansible-advanced-reboot-testcases
Mar 30, 2020
Merged

[pytest] Convert Ansible Advanced Reboot fast/warm reboot test cases#1500
tahmed-dev merged 2 commits intosonic-net:masterfrom
tahmed-dev:taahme/convert-ansible-advanced-reboot-testcases

Conversation

@tahmed-dev
Copy link
Copy Markdown
Contributor

This PR converts current Ansible fast/warm test cases to pytest test
cases. New pytest AdvancedReboot test fixture corresponding to
advanced-reboot.yml, introduced.

signed-off-by: Tamer Ahmed tamer.ahmed@microsoft.com

  • [] Bug fix
  • [] Testbed and Framework(new/improvement)
  • Test case(new/improvement)

Approach

How did you do it?

How did you verify/test it?

pytest platform/test_warm_reboot_multi_sad.py --testbed= --inventory= --testbed_file= --host-pattern= --module-path=../ansible/library --disable_loganalyzer --new_sonic_image=

Any platform specific information?

Supported testbed topology if it's a new test case?

Documentation

This PR converts current Ansible fast/warm test cases to pytest test
cases. New pytest AdvancedReboot test fixture corresponding to
advanced-reboot.yml, introduced.

signed-off-by: Tamer Ahmed <tamer.ahmed@microsoft.com>
Copy link
Copy Markdown
Contributor

@daall daall left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this! See comments. :)

(Like we discussed offline, the arp_responder comments are an FYI for future work. 🚀)

@tahmed-dev tahmed-dev requested a review from daall March 30, 2020 19:00
Copy link
Copy Markdown
Contributor

@daall daall left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but it would be nice to get to the bottom of what's going on here if you have time. :)

EDIT: python 2 happened, we're good here

@tahmed-dev tahmed-dev merged commit 7e73e8a into sonic-net:master Mar 30, 2020
@tahmed-dev tahmed-dev deleted the taahme/convert-ansible-advanced-reboot-testcases branch March 30, 2020 21:45
kazinator-arista pushed a commit to kazinator-arista/sonic-mgmt that referenced this pull request Mar 4, 2026
…or 202012 (sonic-net#7105)

sonic-swss
* [nbrmgrd] added function to parse IP address from APP_DB (sonic-net#1672)
* [MUX/PFCWD] Use in_ports for acls instead of seperate ACL table (sonic-net#1670)
* [mux] VS test for neigh, route and fdb (sonic-net#1656)
* [Dynamic buffer calc] Bug fix: Remove PGs from an administratively down port. (sonic-net#1652)
* spell check fixes (sonic-net#1630)

sonic-utilities
* [reboot]: Stop mux before reboot on dual ToR (sonic-net#1500)
* [config] Disable/enable container monitoring when stopping/starting services (sonic-net#1499)
* Add 'show' and 'clear' command for PG drop (sonic-net#1461)
* [CLI][techsupport] Add NOOP option for commands that did not have that option (sonic-net#1445)
* [202012][reload] Improve reload by using sonic.target (sonic-net#1509)

Signed-off-by: Danny Allen <daall@microsoft.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants