[VRF] Modify some errors for test_bgp_with_loopback in test_vrf.py#1445
Merged
lguohan merged 1 commit intosonic-net:masterfrom Mar 18, 2020
Minkang-Tsai:master
Merged
[VRF] Modify some errors for test_bgp_with_loopback in test_vrf.py#1445lguohan merged 1 commit intosonic-net:masterfrom Minkang-Tsai:master
lguohan merged 1 commit intosonic-net:masterfrom
Minkang-Tsai:master
Conversation
Description of PR 1. Access the asn parameter from /etc/sonic/constants.yml instead of /etc/sonic/deployment_id_asn_map.yml. 2. Don't remove bgp associated with default VRF when there are bgp associated with non default VRF. This is FRR's restriction. Type of change Bug fix [] Testbed and Framework(new/improvement) [] Test case(new/improvement) How did you verify/test it? Run test_bgp_with_loopback again.
Contributor
|
can you post test results? |
Contributor
Author
|
@lguohan I had updated. |
prsunny
approved these changes
Mar 13, 2020
prsunny
reviewed
Mar 13, 2020
kazinator-arista
pushed a commit
to kazinator-arista/sonic-mgmt
that referenced
this pull request
Mar 4, 2026
…or 202012 (sonic-net#7105) sonic-swss * [nbrmgrd] added function to parse IP address from APP_DB (sonic-net#1672) * [MUX/PFCWD] Use in_ports for acls instead of seperate ACL table (sonic-net#1670) * [mux] VS test for neigh, route and fdb (sonic-net#1656) * [Dynamic buffer calc] Bug fix: Remove PGs from an administratively down port. (sonic-net#1652) * spell check fixes (sonic-net#1630) sonic-utilities * [reboot]: Stop mux before reboot on dual ToR (sonic-net#1500) * [config] Disable/enable container monitoring when stopping/starting services (sonic-net#1499) * Add 'show' and 'clear' command for PG drop (sonic-net#1461) * [CLI][techsupport] Add NOOP option for commands that did not have that option (sonic-net#1445) * [202012][reload] Improve reload by using sonic.target (sonic-net#1509) Signed-off-by: Danny Allen <daall@microsoft.com>
kazinator-arista
pushed a commit
to kazinator-arista/sonic-mgmt
that referenced
this pull request
Mar 4, 2026
d03c6ccc90b92d9319c500a8adcf727a9fa5609b (HEAD -> 201911, origin/201911) [intfsorch] Init proxy_arp variable while adding router interface. (sonic-net#1473) 9e7c0bc8e3f2c7c5422f2f8a2c6498f659dcdf84 [drop counters] Clarify log messages for initial counter setup (sonic-net#1445) da8ac754fa1c36f9bb7ba1210017f915f339cfe0 Create vnet tunnel map only if it doesn't exist (sonic-net#1482) Signed-off-by: Abhishek Dosi <abdosi@microsoft.com>
kazinator-arista
pushed a commit
to kazinator-arista/sonic-mgmt
that referenced
this pull request
Mar 4, 2026
Including the following changes: [bitmap_vnet] Remove BMTOR implementation (sonic-net#1496) [intfsorch] Init proxy_arp variable while adding router interface. (sonic-net#1473) [drop counters] Clarify log messages for initial counter setup (sonic-net#1445) Signed-off-by: Liat Grozovik <liatg@nvidia.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of PR
Type of change
How did you verify/test it?
Run test_bgp_with_loopback again.