Skip to content

[pytest/conn_graph_facts] Modify conn_graph_facts to choose appropriate inventory graph#1499

Merged
lguohan merged 3 commits intomasterfrom
conn_graph
Apr 1, 2020
Merged

[pytest/conn_graph_facts] Modify conn_graph_facts to choose appropriate inventory graph#1499
lguohan merged 3 commits intomasterfrom
conn_graph

Conversation

@neethajohn
Copy link
Copy Markdown
Contributor

Signed-off-by: Neetha John nejo@microsoft.com

Description of PR

Add ability to use a different graph xml other than the default 'lab_connection_graph.xml'

Type of change

  • [] Bug fix
  • Testbed and Framework(new/improvement)
  • [] Test case(new/improvement)

Approach

How did you do it?

Created an 'inv_mapping.json' file under group_vars/all which contains the inventory file name to the graph xml mapping
Modify existing conn_graph_facts to choose the graph appropriately.

How did you verify/test it?

Specified mappings in the inv_mapping.json and verified that the correct graph is picked
Without the json file, verified that 'lab_connection_graph.xml' is used

Signed-off-by: Neetha John <nejo@microsoft.com>
@neethajohn neethajohn changed the title Modify conn_graph_facts to choose appropriate inventory graph [pytest/conn_graph_facts] Modify conn_graph_facts to choose appropriate inventory graph Mar 27, 2020
Comment thread tests/common/fixtures/conn_graph_facts.py
Comment thread tests/common/fixtures/conn_graph_facts.py Outdated
Comment thread tests/common/fixtures/conn_graph_facts.py Outdated
@yxieca yxieca self-requested a review March 30, 2020 14:33
Signed-off-by: Neetha John <nejo@microsoft.com>
Comment thread tests/common/fixtures/conn_graph_facts.py Outdated
Signed-off-by: Neetha John <nejo@microsoft.com>
@lguohan lguohan merged commit 71d1843 into master Apr 1, 2020
@lguohan lguohan deleted the conn_graph branch May 19, 2020 18:55
kazinator-arista pushed a commit to kazinator-arista/sonic-mgmt that referenced this pull request Mar 4, 2026
…or 202012 (sonic-net#7105)

sonic-swss
* [nbrmgrd] added function to parse IP address from APP_DB (sonic-net#1672)
* [MUX/PFCWD] Use in_ports for acls instead of seperate ACL table (sonic-net#1670)
* [mux] VS test for neigh, route and fdb (sonic-net#1656)
* [Dynamic buffer calc] Bug fix: Remove PGs from an administratively down port. (sonic-net#1652)
* spell check fixes (sonic-net#1630)

sonic-utilities
* [reboot]: Stop mux before reboot on dual ToR (sonic-net#1500)
* [config] Disable/enable container monitoring when stopping/starting services (sonic-net#1499)
* Add 'show' and 'clear' command for PG drop (sonic-net#1461)
* [CLI][techsupport] Add NOOP option for commands that did not have that option (sonic-net#1445)
* [202012][reload] Improve reload by using sonic.target (sonic-net#1509)

Signed-off-by: Danny Allen <daall@microsoft.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants