Skip to content

Fixes for SNMP Tests Flakiness#14945

Merged
yejianquan merged 5 commits intosonic-net:masterfrom
agadia-cisco:snmp-test-flakiness-issue
Oct 30, 2024
Merged

Fixes for SNMP Tests Flakiness#14945
yejianquan merged 5 commits intosonic-net:masterfrom
agadia-cisco:snmp-test-flakiness-issue

Conversation

@agadia-cisco
Copy link
Copy Markdown
Contributor

@agadia-cisco agadia-cisco commented Oct 10, 2024

Description of PR

Summary: The PR contains changes to snmp_helpers.py which checks whether snmp-subagent process is up or not before proceeding in the test. Accordingly all the snmp tests were updated to accommodate the change. This fixes the SNMP tests failures due to information not gathered in get_snmp_facts.

Fixes # (issue)

Type of change

  • Bug fix
  • Testbed and Framework(new/improvement)
  • Test case(new/improvement)

Back port request

  • 201911
  • 202012
  • 202205
  • 202305
  • 202311
  • 202405

Approach

What is the motivation for this PR?

It has been observed that without snmp-subagent being up, SNMP tests proceeds to execution causing TC failures because snmp_facts isn't able to capture the device information.

How did you do it?

Check was added in snmp_helpers ensuring that snmp-subagent is up before calling snmp_facts. All TCs were updated with the change.

How did you verify/test it?

Had run the changes on 202405 image installed in T0 device & tests passed.

@mssonicbld
Copy link
Copy Markdown
Collaborator

mssonicbld commented Oct 10, 2024

The pre-commit check detected issues in the files touched by this pull request.
The pre-commit check is a mandatory check, please fix detected issues.

Detailed pre-commit check results:
trim trailing whitespace.................................................Passed
fix end of files.........................................................Passed
check yaml...........................................(no files to check)Skipped
check for added large files..............................................Passed
check python ast.........................................................Passed
flake8...................................................................Failed
- hook id: flake8
- exit code: 1

tests/common/helpers/snmp_helpers.py:37:121: E501 line too long (129 > 120 characters)
tests/common/helpers/snmp_helpers.py:38:21: E128 continuation line under-indented for visual indent

flake8...............................................(no files to check)Skipped
check conditional mark sort..........................(no files to check)Skipped

To run the pre-commit checks locally, you can follow below steps:

  1. Ensure that default python is python3. In sonic-mgmt docker container, default python is python2. You can run
    the check by activating the python3 virtual environment in sonic-mgmt docker container or outside of sonic-mgmt
    docker container.
  2. Ensure that the pre-commit package is installed:
sudo pip install pre-commit
  1. Go to repository root folder
  2. Install the pre-commit hooks:
pre-commit install
  1. Use pre-commit to check staged file:
pre-commit
  1. Alternatively, you can check committed files using:
pre-commit run --from-ref <commit_id> --to-ref <commit_id>

@agadia-cisco agadia-cisco marked this pull request as ready for review October 14, 2024 18:21
@vperumal
Copy link
Copy Markdown
Collaborator

vperumal commented Oct 25, 2024

@abdosi @SuvarnaMeenakshi @yejianquan - Can you help review and merge this PR

@yejianquan
Copy link
Copy Markdown
Collaborator

yejianquan commented Oct 27, 2024

/azp run

@azure-pipelines
Copy link
Copy Markdown

azure-pipelines bot commented Oct 27, 2024

Azure Pipelines successfully started running 1 pipeline(s).

yejianquan
yejianquan reviewed Oct 27, 2024
View reviewed changes
@yejianquan
Copy link
Copy Markdown
Collaborator

yejianquan commented Oct 27, 2024

@agadia-cisco @vperumal , added comments, thanks

yejianquan
yejianquan reviewed Oct 30, 2024
View reviewed changes
@yejianquan
Copy link
Copy Markdown
Collaborator

yejianquan commented Oct 30, 2024

@agadia-cisco
Saw you test result in the collapsed comment, next time please paste the test result in the PR description,
And for the 2 failures in the output,
I believe they were here before your change and not related to your change, right?

@agadia-cisco
Copy link
Copy Markdown
Contributor Author

agadia-cisco commented Oct 30, 2024

@agadia-cisco Saw you test result in the collapsed comment, next time please paste the test result in the PR description, And for the 2 failures in the output, I believe they were here before your change and not related to your change, right?

Both the failures are not related to my change & were seen before my changes too.

  • snmp/test_snmp_psu.py::test_snmp_numpsu failure, PR 14860 was already raised & it was merged today.
  • snmp/test_snmp_queue_counters.py::test_snmp_queue_counters failure, we are looking into the issue.

yejianquan
yejianquan approved these changes Oct 30, 2024
View reviewed changes
Copy link
Copy Markdown
Collaborator

@yejianquan yejianquan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@yejianquan yejianquan merged commit c043990 into sonic-net:master Oct 30, 2024
mssonicbld pushed a commit to mssonicbld/sonic-mgmt that referenced this pull request Oct 30, 2024
@agadia-cisco @mssonicbld
Fixes for SNMP Tests Flakiness (sonic-net#14945)
7637018 
Description of PR
Summary: The PR contains changes to snmp_helpers.py which checks whether snmp-subagent process is up or not before proceeding in the test. Accordingly all the snmp tests were updated to accommodate the change. This fixes the SNMP tests failures due to information not gathered in get_snmp_facts.

Approach
What is the motivation for this PR?
It has been observed that without snmp-subagent being up, SNMP tests proceeds to execution causing TC failures because snmp_facts isn't able to capture the device information.

How did you do it?
Check was added in snmp_helpers ensuring that snmp-subagent is up before calling snmp_facts. All TCs were updated with the change.

How did you verify/test it?
Had run the changes on 202405 image installed in T0 device & tests passed.

co-authorized by: jianquanye@microsoft.com
@mssonicbld
Copy link
Copy Markdown
Collaborator

mssonicbld commented Oct 30, 2024

Cherry-pick PR to 202405: #15269

@mssonicbld mssonicbld mentioned this pull request Oct 30, 2024
Merged
9 tasks
mssonicbld pushed a commit that referenced this pull request Oct 30, 2024
@agadia-cisco @mssonicbld
Fixes for SNMP Tests Flakiness (#14945)
30cea1e 
Description of PR
Summary: The PR contains changes to snmp_helpers.py which checks whether snmp-subagent process is up or not before proceeding in the test. Accordingly all the snmp tests were updated to accommodate the change. This fixes the SNMP tests failures due to information not gathered in get_snmp_facts.

Approach
What is the motivation for this PR?
It has been observed that without snmp-subagent being up, SNMP tests proceeds to execution causing TC failures because snmp_facts isn't able to capture the device information.

How did you do it?
Check was added in snmp_helpers ensuring that snmp-subagent is up before calling snmp_facts. All TCs were updated with the change.

How did you verify/test it?
Had run the changes on 202405 image installed in T0 device & tests passed.

co-authorized by: jianquanye@microsoft.com
sreejithsreekumaran pushed a commit to sreejithsreekumaran/sonic-mgmt that referenced this pull request Nov 15, 2024
@agadia-cisco @sreejithsreekumaran
Fixes for SNMP Tests Flakiness (sonic-net#14945)
d1952e6 
Description of PR
Summary: The PR contains changes to snmp_helpers.py which checks whether snmp-subagent process is up or not before proceeding in the test. Accordingly all the snmp tests were updated to accommodate the change. This fixes the SNMP tests failures due to information not gathered in get_snmp_facts.

Approach
What is the motivation for this PR?
It has been observed that without snmp-subagent being up, SNMP tests proceeds to execution causing TC failures because snmp_facts isn't able to capture the device information.

How did you do it?
Check was added in snmp_helpers ensuring that snmp-subagent is up before calling snmp_facts. All TCs were updated with the change.

How did you verify/test it?
Had run the changes on 202405 image installed in T0 device & tests passed.

co-authorized by: jianquanye@microsoft.com
yutongzhang-microsoft pushed a commit to yutongzhang-microsoft/sonic-mgmt that referenced this pull request Nov 21, 2024
@agadia-cisco @yutongzhang-microsoft
Fixes for SNMP Tests Flakiness (sonic-net#14945)
cd1c44b 
Description of PR
Summary: The PR contains changes to snmp_helpers.py which checks whether snmp-subagent process is up or not before proceeding in the test. Accordingly all the snmp tests were updated to accommodate the change. This fixes the SNMP tests failures due to information not gathered in get_snmp_facts.

Approach
What is the motivation for this PR?
It has been observed that without snmp-subagent being up, SNMP tests proceeds to execution causing TC failures because snmp_facts isn't able to capture the device information.

How did you do it?
Check was added in snmp_helpers ensuring that snmp-subagent is up before calling snmp_facts. All TCs were updated with the change.

How did you verify/test it?
Had run the changes on 202405 image installed in T0 device & tests passed.

co-authorized by: jianquanye@microsoft.com
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@yejianquan yejianquan yejianquan approved these changes

Assignees

No one assigned

Labels

Approved for 202405 branch Included in 202405 branch Request for 202405 branch

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@agadia-cisco @mssonicbld @vperumal @yejianquan