fix for test_snmp_numpsu failure#14860
Merged
kevinskwang merged 2 commits intosonic-net:masterfrom Oct 30, 2024
Merged
Conversation
bpar9
requested changes
Oct 8, 2024
Collaborator
bpar9
left a comment
There was a problem hiding this comment.
Can you please fill the Approach Section of the PR and how/where it was verified? rest lgtm
Contributor
Author
|
@bpar9 have updated the PR with approach section. |
Contributor
|
PR test stuck. Let me close and re-open the PR. |
mssonicbld
pushed a commit
to mssonicbld/sonic-mgmt
that referenced
this pull request
Oct 30, 2024
* fix for test_snmp_numpsu tc failure * Trigger Pipeline again
Collaborator
|
Cherry-pick PR to 202405: #15254 |
8 tasks
mssonicbld
pushed a commit
that referenced
this pull request
Oct 30, 2024
* fix for test_snmp_numpsu tc failure * Trigger Pipeline again
9 tasks
Contributor
Author
|
@kevinskwang @wsycqyz Could you please trigger cherry pick PR for |
sreejithsreekumaran
pushed a commit
to sreejithsreekumaran/sonic-mgmt
that referenced
this pull request
Nov 15, 2024
* fix for test_snmp_numpsu tc failure * Trigger Pipeline again
yutongzhang-microsoft
pushed a commit
to yutongzhang-microsoft/sonic-mgmt
that referenced
this pull request
Nov 21, 2024
* fix for test_snmp_numpsu tc failure * Trigger Pipeline again
Contributor
Author
@kevinskwang @wsycqyz Could you please trigger cherry pick PR for |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of PR
Summary:
test_snmp_numpsuTC fails because of change instdoutoutput, observed in202405&202311.Fixes # (issue)
stdout_lineswill be use to fetch thenumpsusvalue, if thestdout_linesis empty / the value can't be typecasted; then in all scenarios TC wouldn't break, instead it will Error out gracefully. Samplestdout_linesconsidered -Type of change
Back port request
Approach
What is the motivation for this PR?
Observed
test_snmp_psufailing in202405&202311images due to change in thestdoutstructure.How did you do it?
Earlier
stdoutoutput was simply getting typecasted, instead now it will usestdout_lines& check its length, if it has a non-zero length, then it will pick the last element & try typecasting it;numpsuscount if exists, will always be the last element in the output.How did you verify/test it?
Run changes with
202405&202311images on aT0setup and all of them passed.