[action] [PR:14945] Fixes for SNMP Tests Flakiness#15269
Merged
mssonicbld merged 1 commit intosonic-net:202405from Oct 30, 2024
Merged
[action] [PR:14945] Fixes for SNMP Tests Flakiness#15269mssonicbld merged 1 commit intosonic-net:202405from
mssonicbld merged 1 commit intosonic-net:202405from
Conversation
Description of PR Summary: The PR contains changes to snmp_helpers.py which checks whether snmp-subagent process is up or not before proceeding in the test. Accordingly all the snmp tests were updated to accommodate the change. This fixes the SNMP tests failures due to information not gathered in get_snmp_facts. Approach What is the motivation for this PR? It has been observed that without snmp-subagent being up, SNMP tests proceeds to execution causing TC failures because snmp_facts isn't able to capture the device information. How did you do it? Check was added in snmp_helpers ensuring that snmp-subagent is up before calling snmp_facts. All TCs were updated with the change. How did you verify/test it? Had run the changes on 202405 image installed in T0 device & tests passed. co-authorized by: jianquanye@microsoft.com
9 tasks
Collaborator
Author
|
Original PR: #14945 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of PR
Summary: The PR contains changes to
snmp_helpers.pywhich checks whethersnmp-subagentprocess is up or not before proceeding in the test. Accordingly all thesnmptests were updated to accommodate the change. This fixes the SNMP tests failures due to information not gathered inget_snmp_facts.Fixes # (issue)
Type of change
Back port request
Approach
What is the motivation for this PR?
It has been observed that without
snmp-subagentbeing up, SNMP tests proceeds to execution causing TC failures becausesnmp_factsisn't able to capture the device information.How did you do it?
Check was added in
snmp_helpersensuring thatsnmp-subagentis up before callingsnmp_facts. All TCs were updated with the change.How did you verify/test it?
Had run the changes on
202405image installed inT0device & tests passed.