Skip to content

[vnet]: Add test for VNET with warm-reboot#1081

Merged
prsunny merged 2 commits intosonic-net:masterfrom
volodymyrsamotiy:vnet_warmreboot
Oct 18, 2019
Merged

[vnet]: Add test for VNET with warm-reboot#1081
prsunny merged 2 commits intosonic-net:masterfrom
volodymyrsamotiy:vnet_warmreboot

Conversation

@volodymyrsamotiy
Copy link
Copy Markdown
Contributor

@volodymyrsamotiy volodymyrsamotiy commented Aug 23, 2019

Signed-off-by: Volodymyr Samotiy volodymyrs@mellanox.com

Description of PR

Summary:
Add test for VNET with warm-reboot

How to run?

ansible-playbook test_sonic.yml -i inventory --limit <testbed_name> -e testbed_name=<testbed_name> -e testbed_type=<topo> -e testcase_name=warm_reboot_vnet

Type of change

  • [] Bug fix
  • [] Testbed and Framework(new/improvement)
  • [*] Test case(new/improvement)

Approach

How did you do it?

Added test for VNET with warm-reboot

How did you verify/test it?

Ran test and verified it passed

Any platform specific information?

N/A

Supported testbed topology if it's a new test case?

T0 only

Documentation

N/A

Signed-off-by: Volodymyr Samotiy <volodymyrs@mellanox.com>
Copy link
Copy Markdown
Collaborator

@liat-grozovik liat-grozovik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

suggest to add to the PR description how to run the test

required_vars:
ptf_host:

warm-reboot-vnet:
Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the list of topologies is aligned with vnet test but not with the warm-reboot test. need to check what is the right topology list

@@ -307,7 +310,9 @@ def FromVM(self, test):
ip_dst=test['src'],
ip_src=test['dst'],
ip_id=108,
Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

too many parameters are set with hard coded values and repeated in different places of the test code.
suggest that all will be defined in one place and used by the different functions/files.

Signed-off-by: Volodymyr Samotiy <volodymyrs@mellanox.com>
@volodymyrsamotiy volodymyrsamotiy marked this pull request as ready for review October 10, 2019 15:43
@prsunny prsunny merged commit 185476f into sonic-net:master Oct 18, 2019
kazinator-arista pushed a commit to kazinator-arista/sonic-mgmt that referenced this pull request Mar 4, 2026
…rm-common] advance submodule head (sonic-net#11578)

linkmgrd:
* e0fe1d4 2022-07-27 | TSA enhancement (sonic-net#98) (HEAD -> 202205) [Jing Zhang]

utilities:
* 7d7e15e 2022-07-18 | [vnet_route_check] Align DB data parse logic with format used by swsscommon API (sonic-net#2268) (HEAD -> 202205) [Volodymyr Samotiy]
* b3d5d18 2022-07-20 | [MultiAsic] sudo reboot command doesn't gracefully stop Asic syncd# on multiasic platform (sonic-net#2258) [Marty Y. Lok]
* 504ebe6 2022-07-08 | Add 'traffic_shift_away' option to config load_minigraph (sonic-net#2240) [tjchadaga]
* 4079e4a 2022-06-20 | Gives cisco-8000 more flexibility to easily add subcommnads under show platform (sonic-net#2213) [Nathan Cohen]
* 46443c6 2022-07-27 | Update db_migrator to support `PORT_QOS_MAP|global` (sonic-net#2205) [bingwang-ms]
* d7fbdd6 2022-05-26 | fix for non-coherent cmis modules (sonic-net#2163) [qinchuanares]
* 79b4439 2022-06-24 | [sfpshow/sfputil] Enhance sfpshow and sfputil to behavior correctly on RJ45 ports (sonic-net#2111) [Kebo Liu]

swss:
* 275f311 2022-07-26 | [DualToR] Handle race condition between tunnel_decap and mux orchestrator (sonic-net#2397) (HEAD -> 202205) [Devesh Pathak]
* 47586e8 2022-07-22 | [EVPN]Fix missing Vlan member update notification in P2MP scenario (sonic-net#2388) [Sudharsan Dhamal Gopalarathnam]
* 7d5c73f 2022-07-19 | [macsecmgr]: Fix cleanup macsec objs if container stop (sonic-net#2376) [Ze Gan]
* c03996f 2022-07-17 | [orchagent]: Enhance initSaiPhyApi (sonic-net#2367) [andywongarista]
* 57890d7 2022-07-27 | Fix for remote system interface not getting created (sonic-net#2364) [skeesara-nokia]
* 1a93ec9 2022-07-13 | Orchagent changes for synchronizing npu/phy device Tx in the data path before enabling transceiver<CMIS compliant> Tx. (sonic-net#2277) [jaganbal-a]

sairedis:
* a4903be 2022-07-20 | Update PN with XPN support (sonic-net#1081) (HEAD -> 202205, github/202205) [Ze Gan]
* 2cb5671 2022-07-27 | Add SAI_OBJECT_TYPE_TUNNEL object to break-before-make list (sonic-net#1075) [Vaibhav Hemant Dixit]

platform-daemon:
* 901c6a1 2022-06-28 | [CMIS]Improved 400G link bring up sequence (sonic-net#254) (HEAD -> 202205) [Prince George]

platform-common:
* f223b3f 2022-07-09 | Support get_port_or_cage_type (sonic-net#288) (HEAD -> 202205) [Stephen Sun]

Signed-off-by: Ying Xie <ying.xie@microsoft.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants