[loganalyzer] Fix the match_file_list accumulating issue#1031
Merged
lguohan merged 2 commits intosonic-net:masterfrom Jul 30, 2019
wangxin:la-match-file-list
Merged
[loganalyzer] Fix the match_file_list accumulating issue#1031lguohan merged 2 commits intosonic-net:masterfrom wangxin:la-match-file-list
lguohan merged 2 commits intosonic-net:masterfrom
wangxin:la-match-file-list
Conversation
added 2 commits
July 24, 2019 21:43
The match_file_list is not initialized to empty list when it is used. The side effect is that when the log analyzer is called multiple times, test match file used in earlier analysis will be used in later analysis and cause issue. The fix is to initialize match_file_list to empty list before using it. Signed-off-by: Xin Wang <xinw@mellanox.com>
lguohan
approved these changes
Jul 30, 2019
fraserg-arista
pushed a commit
to fraserg-arista/sonic-mgmt
that referenced
this pull request
Feb 24, 2026
sonic-net#1031) …nic-net/sonic-mgmt/pull/21142 (sonic-net#22126) What is the motivation for this PR? To enable ipv6 only topo for test_default_route tests. How did you do it? Edit the test code to not require ipv4 when in ipv6 only topo situation. How did you verify/test it? Original PR at: sonic-net#21142
kazinator-arista
pushed a commit
to kazinator-arista/sonic-mgmt
that referenced
this pull request
Mar 4, 2026
) Remove duplicate cisco-8000 functions and call to those functions (sonic-net#1077) Support For CISCO debug-shell in syncd-container (sonic-net#1070) Fix submodule SAI branch name (sonic-net#1031) Signed-off-by: Kevin Wang <shengkaiwang@microsoft.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of PR
Summary:
Fixes # (issue)
The match_file_list is not initialized to empty list when it is used.
The side effect is that when the log analyzer is called multiple times,
test match file used in earlier analysis will be used in later analysis
and cause issue. The fix is to initialize match_file_list to empty list
before using it.
Related PRs:
Type of change
Approach
How did you do it?
Initilize the match_file_list to empty list before using it.
How did you verify/test it?
Tested on Mellanox platform.
Any platform specific information?
NA
Supported testbed topology if it's a new test case?
NA
Documentation