[loganalyzer] Fix the IOError of opening match file#994
Merged
qiluo-msft merged 2 commits intosonic-net:masterfrom Jul 9, 2019
wangxin:la-ioerror
Merged
[loganalyzer] Fix the IOError of opening match file#994qiluo-msft merged 2 commits intosonic-net:masterfrom wangxin:la-ioerror
qiluo-msft merged 2 commits intosonic-net:masterfrom
wangxin:la-ioerror
Conversation
Signed-off-by: Xin Wang <xinw@mellanox.com>
ansible/roles/test/files/tools/loganalyzer/loganalyzer_analyze.yml
Outdated
Show resolved
Hide resolved
liat-grozovik
approved these changes
Jul 7, 2019
| match_file_list: "{{ match_file_list | default([]) }} + {{ [test_match_file] }}" | ||
| when: test_match_file is defined | ||
|
|
||
| - name: Add mmatch file option |
lguohan
approved these changes
Jul 8, 2019
1 task
sdszhang
pushed a commit
to sdszhang/sonic-mgmt
that referenced
this pull request
Mar 23, 2026
<!-- Please make sure you've read and understood our contributing guidelines; https://github.com/sonic-net/SONiC/blob/gh-pages/CONTRIBUTING.md Please provide following information to help code review process a bit easier: --> ### Description of PR <!-- - Please include a summary of the change and which issue is fixed. - Please also include relevant motivation and context. Where should reviewer start? background context? - List any dependencies that are required for this change. --> Summary: This add params for the qos sai tests for t0-f2-d40u8 ### Type of change <!-- - Fill x for your type of change. - e.g. - [x] Bug fix --> - [ ] Bug fix - [ ] Testbed and Framework(new/improvement) - [ ] New Test case - [ ] Skipped for non-supported platforms - [ ] Test case improvement ### Back port request - [ ] 202205 - [ ] 202305 - [ ] 202311 - [ ] 202405 - [ ] 202411 - [ ] 202505 - [ ] 202511 ### Approach #### What is the motivation for this PR? #### How did you do it? #### How did you verify/test it? #### Any platform specific information? #### Supported testbed topology if it's a new test case? ### Documentation <!-- (If it's a new feature, new test case) Did you update documentation/Wiki relevant to your implementation? Link to the wiki page? -->
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of PR
Summary:
Fixes # (issue)
After PR #970 was merged, log analyzer may fail with
IOError: [Errno 2] No such file or directory: ''It was caused by an extra comma appended to the common match file name. In the below ansible log, we can see that the match file list option
-m loganalyzer_common_match.txt,has an unnecessary comma suffix. While parsing argument, loganalyzer.py would try to open a list of match files separated by comma. The second file in the list has empty file name and will cause the error.Adjust location of the comma can fix the issue.
Type of change
Approach
How did you do it?
Move the comma to correct location.
How did you verify/test it?
Tested on Mellanox platform
Any platform specific information?
N/A
Supported testbed topology if it's a new test case?
Documentation