Skip to content

Add new test case to verify MAC address is correct after SONiC to SONiC update#970

Merged
qiluo-msft merged 4 commits intosonic-net:masterfrom
yvolynets-mlnx:none_mac_test
Jun 27, 2019
Merged

Add new test case to verify MAC address is correct after SONiC to SONiC update#970
qiluo-msft merged 4 commits intosonic-net:masterfrom
yvolynets-mlnx:none_mac_test

Conversation

@yvolynets-mlnx
Copy link
Copy Markdown
Contributor

Description of PR (Draft)

Added new test case to verify MAC address is correct after SONiC-to-SONiC update.

Test case performs:

  • SONiC-to-SONiC update
  • Verifies that MAC address was read correctly and its value fits the MAC address template after image update

Test case steps:

  • Parse parameters: image1, image2, iterations
    In the loop:
  • Select/flip image
  • Download selected image and copy it to the device
  • Init loganalyzer
  • Install copied image
  • Reboot device
  • Verify MAC address fits "xx:xx:xx:xx:xx:xx" template
  • Run loganalyzer
  • Analyze loganalyzer results

Test case parameters:
image1,image2 - URL to the SONIC binary image
iterations - Number of times to switch between two images and perform MAC verification

PASS/FAIL criteria:
After install SONiC image and reboot device:

  • MAC address in CONFIG_DB must match to 6 byte template "xx:xx:xx:xx:xx:xx"
  • Error messages about "None" MAC address are absent in Syslog

Summary:
Fixes #

Type of change

  • [] Bug fix
  • [] Testbed and Framework(new/improvement)
  • New test case

Approach

How did you do it?

How did you verify/test it?

Tested on our local testbed.
Test case expect the following parameters:
-e image1=http://IP_ADDR/SERVER_URL/IMAGE_NAME.bin
-e image2=http://IP_ADDR/SERVER_URL/IMAGE_NAME.bin
-e iterations=INT_NUMBER

Any platform specific information?

Supported testbed topology if it's a new test case?

Documentation

Notes

As it is draft PR, new features/improvements are planned to be added:

  • Add option to copy and load minigraph after device reboot (to be able to run this test case on older and newer images) with similar expected behavior
  • Update "read_mac_metadata_loop.yml" to use "reduce_and_add_sonic_images.yml"
  • Check that password can be passed from shell, if not add such possibility

- fail: msg="Please speify URL to the image1"
when: image1 is not defined

- fail: msg="Please speify URL to the image2"
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fai [](start = 4, length = 3)

Also check image1 != image2

Copy link
Copy Markdown
Contributor

@qiluo-msft qiluo-msft left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As comment

@yvolynets-mlnx yvolynets-mlnx marked this pull request as ready for review June 27, 2019 15:09
@qiluo-msft qiluo-msft merged commit b83f0af into sonic-net:master Jun 27, 2019
auspham pushed a commit to auspham/sonic-mgmt that referenced this pull request Feb 3, 2026
<!--
Please make sure you've read and understood our contributing guidelines;
https://github.com/sonic-net/SONiC/blob/gh-pages/CONTRIBUTING.md

Please provide following information to help code review process a bit easier:
-->
### Description of PR
<!--
- Please include a summary of the change and which issue is fixed.
- Please also include relevant motivation and context. Where should reviewer start? background context?
- List any dependencies that are required for this change.
-->

Summary:
add vips in f2 t1 topo

### Type of change

<!--
- Fill x for your type of change.
- e.g.
- [x] Bug fix
-->

- [ ] Bug fix
- [ ] Testbed and Framework(new/improvement)
- [ ] New Test case
 - [ ] Skipped for non-supported platforms
- [ ] Test case improvement

### Back port request
- [ ] 202205
- [ ] 202305
- [ ] 202311
- [ ] 202405
- [ ] 202411
- [ ] 202505
- [ ] 202511

### Approach
#### What is the motivation for this PR?
add vips in f2 t1 topo

#### How did you do it?

#### How did you verify/test it?

#### Any platform specific information?

#### Supported testbed topology if it's a new test case?

### Documentation
<!--
(If it's a new feature, new test case)
Did you update documentation/Wiki relevant to your implementation?
Link to the wiki page?
-->
kazinator-arista pushed a commit to kazinator-arista/sonic-mgmt that referenced this pull request Mar 4, 2026
…omatically (sonic-net#21665)

#### Why I did it
src/sonic-swss-common
```
* 8f47a37 - (HEAD -> 202411, origin/202411) Handle 'bulkget' in consumer_table_pops.lua (sonic-net#970) (25 hours ago) [mssonicbld]
```
#### How I did it
#### How to verify it
#### Description for the changelog
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants