Conversation
added 30 commits
April 25, 2020 13:29
…actored classifiers/regressor, all tests pass
* refactored PCA
…rison of nested data frames to account for unequal length series
* Refactor to make dictionary classifiers/transforms pass package pytest. Inclusion of WEASEL bigrams/igb methods in SFA.
* refactor mrseql to pass all the tests * add multivariate support
* Refactored Rocket
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this implement/fix? Explain your changes.
Major refactoring and clean up of existing functionality:
Comments
I had to remove a few classes which I couldn't make compliant with the basic scikit-learn API without major work, including
transformers/spectral_based, see Refactoring transformers/spectral_based #224 for refactoring and adding it backGridSearchCVas it was essentially the same as the one in scikit-learnHomogeneousColumnEnsembleClassifier, but we still have the more flexibleColumnEnsembleClassifiercheck_inputkwarg (or parameter passed to fit)highlevel/tobenchmarking/, removedhighlevel/Pipeline, but sklearn's pipeline should be fully compatible