Skip to content

Package refactoring #246

Merged
mloning merged 43 commits intodevfrom
refactor
May 27, 2020
Merged

Package refactoring #246
mloning merged 43 commits intodevfrom
refactor

Conversation

@mloning
Copy link
Copy Markdown
Contributor

@mloning mloning commented Apr 25, 2020

What does this implement/fix? Explain your changes.

Major refactoring and clean up of existing functionality:

Comments

I had to remove a few classes which I couldn't make compliant with the basic scikit-learn API without major work, including

  • transformers/spectral_based, see Refactoring transformers/spectral_based  #224 for refactoring and adding it back
  • removed our version of GridSearchCV as it was essentially the same as the one in scikit-learn
  • HomogeneousColumnEnsembleClassifier, but we still have the more flexible ColumnEnsembleClassifier
  • removed optional check_input kwarg (or parameter passed to fit)
  • moved strategies and tasks from highlevel/ to benchmarking/, removed highlevel/
  • removed our Pipeline, but sklearn's pipeline should be fully compatible

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

implementing framework Implementing or improving framework for learning tasks, e.g., base class functionality maintenance Continuous integration, unit testing & package distribution

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Enforce linting Folder structure Implement consistent input checks

5 participants