-
-
Notifications
You must be signed in to change notification settings - Fork 2k
Closed
Labels
good first issueGood for newcomersGood for newcomersimplementing algorithmsImplementing algorithms, estimators, objects native to sktimeImplementing algorithms, estimators, objects native to sktime
Description
During an informal code review, I noticed that transformers/spectral_based.py use a custom mechanism to do the same as applying the compositor RowWiseTransformer from sktime.transformers.compose to single-series-transformers would do.
Should this be re-factored?
I believe @jsellier wrote the original version in an early stag of the project where RowWiseTransformer may not yet have existed.
Reactions are currently unavailable
Metadata
Metadata
Assignees
Labels
good first issueGood for newcomersGood for newcomersimplementing algorithmsImplementing algorithms, estimators, objects native to sktimeImplementing algorithms, estimators, objects native to sktime