Dictionary Based Refactor#263
Merged
mloning merged 16 commits intosktime:refactorfrom May 22, 2020
MatthewMiddlehurst:refactor
Merged
Dictionary Based Refactor#263mloning merged 16 commits intosktime:refactorfrom MatthewMiddlehurst:refactor
mloning merged 16 commits intosktime:refactorfrom
MatthewMiddlehurst:refactor
Conversation
added 2 commits
May 20, 2020 11:38
Inclusion of WEASEL bigrams/igb methods in SFA.
mloning
reviewed
May 20, 2020
added 10 commits
May 20, 2020 12:42
Maybe becuase output is a dictionary/pd.series and tabularize breaks it?
mloning
reviewed
May 22, 2020
Contributor
mloning
left a comment
There was a problem hiding this comment.
Looks good, thanks for all of the changes! I've left two minor comments.
sktime/transformers/series_as_features/dictionary_based/__init__.py
Outdated
Show resolved
Hide resolved
added 4 commits
May 22, 2020 11:19
This reverts commit 90e050e
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reference Issues/PRs
Fixes the dictionary based classifiers and transformers mentioned in issue #257:
BOSSEnsemble
SFA
SAX
What does this implement/fix? Explain your changes.
Allows the stated estimators to successfully pass check_estimator().
Additionally, introduced some methods necessary for the WEASEL dictionary based classifier into the SFA transformer.