Merged
Conversation
Contributor
|
Hi @lnthach, thanks for the fixes, looks good to me. Let me know when you're all done so that I can merge it 🙂 |
Contributor
Author
|
Thanks @mloning . Sorry for the late response. Yes it's good to go from my side. |
Contributor
|
No worries, thanks for the fixes! 🙂 |
Contributor
Contributor
Author
|
Hi @mloning , Many thanks for pointing that out. It appeared that the way I sliced the dataframe wasn't optimal. I have implemented the fix for this issue. Can I make my pull request on dev ? |
Contributor
|
Yes please! Thanks @lnthach |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reference Issues/PRs
See #257
What does this implement/fix? Explain your changes.
Refactor Mr-SEQL to pass all the tests for estimators.
Add multivariate time series support. MrSEQLClassifier can classify multivariate time series now.
Update notebook example.