fix word break in facets by adding ul.tight-bullets li word-break: break-all#1794
Merged
simonw merged 1 commit intosimonw:mainfrom Sep 6, 2022
Merged
fix word break in facets by adding ul.tight-bullets li word-break: break-all#1794simonw merged 1 commit intosimonw:mainfrom
simonw merged 1 commit intosimonw:mainfrom
Conversation
Owner
|
Thanks for this - I've seen this issue too. Good fix. |
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I noticed that long words break the layout of facets:
So I added CSS to add a line break. This is how the result looks now:
I don't know enough about facet edge cases to decide if this change might break other things but it looks better for me so maybe this is helpful.
📚 Documentation preview 📚: https://datasette--1794.org.readthedocs.build/en/1794/