Skip to content

Database() constructor currently defaults is_mutable to False #1808

New issue
New issue
Closed
Closed
Database() constructor currently defaults is_mutable to False#1808
Labels
bugplugins
@simonw

Description

@simonw
simonw
opened on Sep 9, 2022

This is surprising. It caused a bug in datasette-upload-dbs because I didn't expect it to do that.

I think this is an API design flaw in Datasette itself, but I can fix it here first.

Originally posted by @simonw in simonw/datasette-upload-dbs#6 (comment)

Code in question:

datasette/datasette/database.py

Lines 29 to 32 in bf8d84a

class Database:
def __init__(
self, ds, path=None, is_mutable=False, is_memory=False, memory_name=None
):

Metadata

Metadata

Assignees

No one assigned

    Labels

    bugplugins

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions