Add Authorization header when CORS flag is set#1467
Closed
jameslittle230 wants to merge 2 commits intosimonw:mainfrom
Closed
Add Authorization header when CORS flag is set#1467jameslittle230 wants to merge 2 commits intosimonw:mainfrom
jameslittle230 wants to merge 2 commits intosimonw:mainfrom
Conversation
Owner
|
This looks like a good fix to me. |
Owner
|
The test there failed because it turns out there's a whole bunch of places that set the |
simonw
added a commit
that referenced
this pull request
Oct 14, 2021
simonw
added a commit
that referenced
this pull request
Oct 14, 2021
Author
|
Yay! Thank you @simonw!! |
simonw
added a commit
that referenced
this pull request
Oct 24, 2021
simonw
added a commit
that referenced
this pull request
Oct 24, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds the
Access-Control-Allow-Headersflag when CORS mode is enabled.This would fix simonw/datasette-auth-tokens#4. When making cross-origin requests, the server must respond with all allowable HTTP headers. A Datasette instance using auth tokens must accept the
AuthorizationHTTP header in order for cross-origin authenticated requests to take place.Please let me know if there's a better way of doing this! I couldn't figure out a way to change the app's response from the plugin itself, so I'm starting here. If you'd rather this logic live in the plugin, I'd love any guidance you're able to give.