[Merged by Bors] - Remove sync await points#3036
Closed
divagant-martian wants to merge 64 commits intosigp:unstablefrom
Closed
[Merged by Bors] - Remove sync await points#3036divagant-martian wants to merge 64 commits intosigp:unstablefrom
divagant-martian wants to merge 64 commits intosigp:unstablefrom
Conversation
Contributor
Author
|
@AgeManning this is running in Toronto to dissuade some doubts I have, but it's otherwise ready. Multiple peers per requests is in the next pr |
Contributor
Author
|
Let's wait a bit more on this |
Contributor
Author
|
Ready again thanks to @pawanjay176 |
Contributor
Author
|
@michaelsproul why is this blocked? |
Member
was blocked on the v2.1.4 release but should be good to go now I think! |
Member
|
bors r+ |
bors bot
pushed a commit
that referenced
this pull request
Mar 21, 2022
## Issue Addressed Removes the await points in sync waiting for a processor response for rpc block processing. Built on top of #3029 This also handles a couple of bugs in the previous code and adds a relatively comprehensive test suite.
|
Build failed: |
Member
|
looks like the Python versioning issue that @realbigsean recently fixed in #3056. not sure why it would be inconsistent, let's try again bors retry |
bors bot
pushed a commit
that referenced
this pull request
Mar 21, 2022
## Issue Addressed Removes the await points in sync waiting for a processor response for rpc block processing. Built on top of #3029 This also handles a couple of bugs in the previous code and adds a relatively comprehensive test suite.
|
Build failed: |
Member
|
Now that #3105 is merged let's try again bors retry |
bors bot
pushed a commit
that referenced
this pull request
Mar 22, 2022
## Issue Addressed Removes the await points in sync waiting for a processor response for rpc block processing. Built on top of #3029 This also handles a couple of bugs in the previous code and adds a relatively comprehensive test suite.
|
Build failed: |
Member
|
🙏 bors + |
|
Did you mean "r+"? |
Member
|
bors r+ |
bors bot
pushed a commit
that referenced
this pull request
Mar 23, 2022
## Issue Addressed Removes the await points in sync waiting for a processor response for rpc block processing. Built on top of #3029 This also handles a couple of bugs in the previous code and adds a relatively comprehensive test suite.
paulhauner
pushed a commit
to paulhauner/lighthouse
that referenced
this pull request
May 6, 2022
## Issue Addressed Removes the await points in sync waiting for a processor response for rpc block processing. Built on top of sigp#3029 This also handles a couple of bugs in the previous code and adds a relatively comprehensive test suite.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue Addressed
Removes the await points in sync waiting for a processor response for rpc block processing. Built on top of #3029
This also handles a couple of bugs in the previous code and adds a relatively comprehensive test suite.