Skip to content

[Merged by Bors] - Updates to tests and local testnet for Ganache 7 #3056

Closed
realbigsean wants to merge 13 commits intosigp:unstablefrom
realbigsean:update-tests-ganache-0.7
Closed

[Merged by Bors] - Updates to tests and local testnet for Ganache 7 #3056
realbigsean wants to merge 13 commits intosigp:unstablefrom
realbigsean:update-tests-ganache-0.7

Conversation

@realbigsean
Copy link
Copy Markdown
Member

@realbigsean realbigsean commented Mar 3, 2022 •
edited
Loading

Issue Addressed

#2961

Proposed Changes

-- update --chainId -> --chain.chainId
-- remove --keepAliveTimeout
-- fix log to listen for
-- rename ganache-cli to ganache everywhere

@realbigsean
-update --chainId -> --chain.chainId
10707e3 
-remove `--keepAliveTimeout`
-fix log to listen for
@realbigsean
rename ganache-cli to ganache
04868e6
@realbigsean realbigsean added low-hanging-fruit Easy to resolve, get it before someone else does! ready-for-review The code is ready for review labels Mar 3, 2022
paulhauner
paulhauner approved these changes Mar 3, 2022
View reviewed changes
Copy link
Copy Markdown
Member

@paulhauner paulhauner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@paulhauner paulhauner added ready-for-merge This PR is ready to merge. and removed ready-for-review The code is ready for review labels Mar 3, 2022
@paulhauner
Copy link
Copy Markdown
Member

paulhauner commented Mar 3, 2022

bors r+

bors bot pushed a commit that referenced this pull request Mar 3, 2022
@realbigsean
Updates to tests and local testnet for Ganache 7 (#3056)
f3ce4d4 
## Issue Addressed

#2961

## Proposed Changes

-- update `--chainId` -> `--chain.chainId`
-- remove `--keepAliveTimeout`
-- fix log to listen for
-- rename `ganache-cli` to `ganache` everywhere


Co-authored-by: realbigsean <sean@sigmaprime.io>
@bors
Copy link
Copy Markdown

bors bot commented Mar 3, 2022

Build failed (retrying...):

bors bot pushed a commit that referenced this pull request Mar 3, 2022
@realbigsean
Updates to tests and local testnet for Ganache 7 (#3056)
a24bd98 
## Issue Addressed

#2961

## Proposed Changes

-- update `--chainId` -> `--chain.chainId`
-- remove `--keepAliveTimeout`
-- fix log to listen for
-- rename `ganache-cli` to `ganache` everywhere


Co-authored-by: realbigsean <sean@sigmaprime.io>
@bors
Copy link
Copy Markdown

bors bot commented Mar 3, 2022

Build failed:

@realbigsean
Copy link
Copy Markdown
Member Author

realbigsean commented Mar 3, 2022

Dang not sure why windows is failing, will have to check it out tomorrow

@realbigsean
Copy link
Copy Markdown
Member Author

realbigsean commented Mar 3, 2022

Strange cause it seems like ganache installed successfully on windows in this run https://github.com/sigp/lighthouse/actions/runs/1930473256

@paulhauner
Copy link
Copy Markdown
Member

paulhauner commented Mar 3, 2022

bors r-

@paulhauner paulhauner added work-in-progress PR is a work-in-progress and removed ready-for-merge This PR is ready to merge. labels Mar 3, 2022
@realbigsean
Copy link
Copy Markdown
Member Author

realbigsean commented Mar 4, 2022

Attempting to match the deps used in the ganache githuba actions workflows: https://github.com/trufflesuite/ganache/blob/1d68fd03b8d03f129b9435a2cc1fcd6d270141a0/.github/workflows/pr.yml

@realbigsean
Copy link
Copy Markdown
Member Author

realbigsean commented Mar 4, 2022

No dice, trying this now: https://github.com/trufflesuite/ganache/blob/f2d1515a4eb26d9f326341cf3902ec09a04a8710/CONTRIBUTING.md#on-windows

realbigsean
realbigsean commented Mar 4, 2022
View reviewed changes
realbigsean
realbigsean commented Mar 4, 2022
View reviewed changes
realbigsean
realbigsean commented Mar 4, 2022
View reviewed changes
realbigsean
realbigsean commented Mar 4, 2022
View reviewed changes
realbigsean
realbigsean commented Mar 4, 2022
View reviewed changes
realbigsean
realbigsean commented Mar 4, 2022
View reviewed changes
@realbigsean realbigsean added ready-for-review The code is ready for review backwards-incompat Backwards-incompatible API change and removed work-in-progress PR is a work-in-progress labels Mar 8, 2022
@realbigsean
Copy link
Copy Markdown
Member Author

realbigsean commented Mar 8, 2022

Ok hopefully this works on bors now. I think the issue was the version of python being used in the build process on windows. I've marked this as backward-incompat because tests and the local simulator will now break if ganache V7 is not installed. But there's nothing outside of tests/local testnet affected.

michaelsproul
michaelsproul approved these changes Mar 20, 2022
View reviewed changes
Copy link
Copy Markdown
Member

@michaelsproul michaelsproul left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM let's try this again

@michaelsproul michaelsproul mentioned this pull request Mar 20, 2022
Closed
@michaelsproul
Copy link
Copy Markdown
Member

michaelsproul commented Mar 20, 2022

bors r+

bors bot pushed a commit that referenced this pull request Mar 20, 2022
@realbigsean
Updates to tests and local testnet for Ganache 7 (#3056)
ae5b141 
## Issue Addressed

#2961

## Proposed Changes

-- update `--chainId` -> `--chain.chainId`
-- remove `--keepAliveTimeout`
-- fix log to listen for
-- rename `ganache-cli` to `ganache` everywhere


Co-authored-by: realbigsean <sean@sigmaprime.io>
@michaelsproul michaelsproul added ready-for-merge This PR is ready to merge. and removed ready-for-review The code is ready for review labels Mar 20, 2022
@bors
Copy link
Copy Markdown

bors bot commented Mar 21, 2022

Pull request successfully merged into unstable.

Build succeeded:

@bors bors bot changed the title Updates to tests and local testnet for Ganache 7 [Merged by Bors] - Updates to tests and local testnet for Ganache 7 Mar 21, 2022
@bors bors bot closed this Mar 21, 2022
@michaelsproul michaelsproul mentioned this pull request Mar 21, 2022
Closed
divagant-martian pushed a commit to divagant-martian/lighthouse that referenced this pull request Mar 22, 2022
@realbigsean @divagant-martian
Updates to tests and local testnet for Ganache 7 (sigp#3056)
dd25a01 
## Issue Addressed

sigp#2961

## Proposed Changes

-- update `--chainId` -> `--chain.chainId`
-- remove `--keepAliveTimeout`
-- fix log to listen for
-- rename `ganache-cli` to `ganache` everywhere


Co-authored-by: realbigsean <sean@sigmaprime.io>
paulhauner pushed a commit to paulhauner/lighthouse that referenced this pull request May 6, 2022
@realbigsean @paulhauner
Updates to tests and local testnet for Ganache 7 (sigp#3056)
2d6b907 
## Issue Addressed

sigp#2961

## Proposed Changes

-- update `--chainId` -> `--chain.chainId`
-- remove `--keepAliveTimeout`
-- fix log to listen for
-- rename `ganache-cli` to `ganache` everywhere


Co-authored-by: realbigsean <sean@sigmaprime.io>
@pawanjay176 pawanjay176 mentioned this pull request Jul 5, 2022
Closed
@realbigsean realbigsean deleted the update-tests-ganache-0.7 branch November 21, 2023 16:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@michaelsproul michaelsproul michaelsproul approved these changes

@paulhauner paulhauner paulhauner approved these changes

Assignees

No one assigned

Labels

backwards-incompat Backwards-incompatible API change low-hanging-fruit Easy to resolve, get it before someone else does! ready-for-merge This PR is ready to merge.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@realbigsean @paulhauner @michaelsproul