[Merged by Bors] - Custom RPC request management for sync#3029
Closed
divagant-martian wants to merge 1 commit intosigp:unstablefrom
Closed
[Merged by Bors] - Custom RPC request management for sync#3029divagant-martian wants to merge 1 commit intosigp:unstablefrom
divagant-martian wants to merge 1 commit intosigp:unstablefrom
Conversation
Member
|
I am getting through this. There seems to be a few changes in the sync manager, but looks like its mostly due to the request id segregation and you've split things into their own functions. Should finish the review soon |
AgeManning
approved these changes
Feb 28, 2022
Member
AgeManning
left a comment
There was a problem hiding this comment.
The changes look good.
Have you tested this over a syncing node? And watched a live node for errors in doing single block lookups?
Might be worth checking how this behaves over these cases, make sure nothing was missed.
Contributor
Author
|
This has been running in fremont for more than a week without problem 👍 |
Member
|
bors r+ |
bors bot
pushed a commit
that referenced
this pull request
Mar 1, 2022
## Proposed Changes Make `lighthouse_network` generic over request ids, now usable by sync
|
Build failed (retrying...): |
bors bot
pushed a commit
that referenced
this pull request
Mar 1, 2022
## Proposed Changes Make `lighthouse_network` generic over request ids, now usable by sync
|
Build failed: |
Member
|
bors r+ |
|
Canceled. |
Member
|
bors r+ |
|
Merge conflict. |
e6493af to
c75c938
Compare
Member
|
bors r+ |
bors bot
pushed a commit
that referenced
this pull request
Mar 2, 2022
## Proposed Changes Make `lighthouse_network` generic over request ids, now usable by sync
|
Pull request successfully merged into unstable. Build succeeded: |
bors bot
pushed a commit
that referenced
this pull request
Mar 14, 2022
## Issue Addressed Removes the await points in sync waiting for a processor response for rpc block processing. Built on top of #3029 This also handles a couple of bugs in the previous code and adds a relatively comprehensive test suite.
bors bot
pushed a commit
that referenced
this pull request
Mar 21, 2022
## Issue Addressed Removes the await points in sync waiting for a processor response for rpc block processing. Built on top of #3029 This also handles a couple of bugs in the previous code and adds a relatively comprehensive test suite.
bors bot
pushed a commit
that referenced
this pull request
Mar 21, 2022
## Issue Addressed Removes the await points in sync waiting for a processor response for rpc block processing. Built on top of #3029 This also handles a couple of bugs in the previous code and adds a relatively comprehensive test suite.
bors bot
pushed a commit
that referenced
this pull request
Mar 22, 2022
## Issue Addressed Removes the await points in sync waiting for a processor response for rpc block processing. Built on top of #3029 This also handles a couple of bugs in the previous code and adds a relatively comprehensive test suite.
bors bot
pushed a commit
that referenced
this pull request
Mar 23, 2022
## Issue Addressed Removes the await points in sync waiting for a processor response for rpc block processing. Built on top of #3029 This also handles a couple of bugs in the previous code and adds a relatively comprehensive test suite.
paulhauner
pushed a commit
to paulhauner/lighthouse
that referenced
this pull request
May 6, 2022
## Issue Addressed Removes the await points in sync waiting for a processor response for rpc block processing. Built on top of sigp#3029 This also handles a couple of bugs in the previous code and adds a relatively comprehensive test suite.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed Changes
Make
lighthouse_networkgeneric over request ids, now usable by sync