Skip to content

chore: drop node v0.10 support#368

Merged
nfischer merged 1 commit intomasterfrom
drop-v0.10-support
Feb 24, 2016
Merged

chore: drop node v0.10 support#368
nfischer merged 1 commit intomasterfrom
drop-v0.10-support

Conversation

@ariporad
Copy link
Copy Markdown
Contributor

Drop Node v0.10 support and document.

- NODE_VERSION="0.10"
- NODE_VERSION="0.11"
- NODE_VERSION="0.12"
- NODE_VERSION="iojs-v1"
Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I realized we weren't testing these, so I added them.

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We intentionally dropped v0.11 support because it's supposed to be compatible with v0.12. See #307.

Artur took out iojs support a month or so ago. Didn't iojs and node merge, so there's no reason to test against these versions? I could be mistaken, so please correct me if I'm wrong.

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

^ the commit I'm referring to is 6acfbe8

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@nfischer: I know v0.11 is supposed to be the same as v0.12, but I feel like it's probably worth testing.

As for iojs, yes, node >4 are actually iojs releases. So the release line looks like this(-ish):

v0.9 --- v0.10 ---- v0.11 --- v0.12 ---- v0.13 --- v0.14 --- v4.0 --- v5.0 --- [Future]
               \                                           /
                 ------ v1.0 ------ v2.0 ------ v3.0 -----

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If iojs is merged back into the project, shouldn't it be ok to drop support for it? Is iojs actually still supported, or was it dropped in favor of node 4?

From #307:

0.11 is an unstable version that is not supported or updated anymore. 0.12 is fully compatible with 0.11 and as it is in maintenance mode, no breaking changes will be committed there.

Since it just slows CI down, and I don't see a strong benefit, I'd vote against including these versions.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not super strong on it, but I feel like we should test any version that we claim to support, just in case theres an incompatibilities.

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In that case, I'd rather stick with supporting v0.12, v4, and v5 in that case. It's essentially the same as what we're testing on now (minus v0.10), and we don't have to worry about all the differences iojs might have going forward.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmm...

I think that we should support (and therefore test) any active, LTS, or maintenance version of node (less v0.10). That would mean v0.11, v0.12, all releases of iojs, and node 4/5.

I doubt it would slow down travis that much, but if we really wanted to make it run fast, we could enable travis fast finishing.

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I suppose this is fine then

@nfischer
Copy link
Copy Markdown
Member

@ariporad Please update the engines attribute inside package.json to be >=0.11. Then this is good to merge.

Also document that we don't support v0.10, and build on iojs. (And don't
send travis emails).
@ariporad
Copy link
Copy Markdown
Contributor Author

@nfischer: Good Catch! Fixed.

@nfischer
Copy link
Copy Markdown
Member

LGTM!

nfischer added a commit that referenced this pull request Feb 24, 2016
@nfischer nfischer merged commit 04b0472 into master Feb 24, 2016
@nfischer nfischer deleted the drop-v0.10-support branch February 24, 2016 20:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants