Conversation
| - NODE_VERSION="0.10" | ||
| - NODE_VERSION="0.11" | ||
| - NODE_VERSION="0.12" | ||
| - NODE_VERSION="iojs-v1" |
There was a problem hiding this comment.
I realized we weren't testing these, so I added them.
There was a problem hiding this comment.
We intentionally dropped v0.11 support because it's supposed to be compatible with v0.12. See #307.
Artur took out iojs support a month or so ago. Didn't iojs and node merge, so there's no reason to test against these versions? I could be mistaken, so please correct me if I'm wrong.
There was a problem hiding this comment.
@nfischer: I know v0.11 is supposed to be the same as v0.12, but I feel like it's probably worth testing.
As for iojs, yes, node >4 are actually iojs releases. So the release line looks like this(-ish):
v0.9 --- v0.10 ---- v0.11 --- v0.12 ---- v0.13 --- v0.14 --- v4.0 --- v5.0 --- [Future]
\ /
------ v1.0 ------ v2.0 ------ v3.0 -----
There was a problem hiding this comment.
If iojs is merged back into the project, shouldn't it be ok to drop support for it? Is iojs actually still supported, or was it dropped in favor of node 4?
From #307:
0.11 is an unstable version that is not supported or updated anymore. 0.12 is fully compatible with 0.11 and as it is in maintenance mode, no breaking changes will be committed there.
Since it just slows CI down, and I don't see a strong benefit, I'd vote against including these versions.
There was a problem hiding this comment.
I'm not super strong on it, but I feel like we should test any version that we claim to support, just in case theres an incompatibilities.
There was a problem hiding this comment.
In that case, I'd rather stick with supporting v0.12, v4, and v5 in that case. It's essentially the same as what we're testing on now (minus v0.10), and we don't have to worry about all the differences iojs might have going forward.
There was a problem hiding this comment.
Hmm...
I think that we should support (and therefore test) any active, LTS, or maintenance version of node (less v0.10). That would mean v0.11, v0.12, all releases of iojs, and node 4/5.
I doubt it would slow down travis that much, but if we really wanted to make it run fast, we could enable travis fast finishing.
b3ad6af to
bcdbe8e
Compare
|
@ariporad Please update the |
Also document that we don't support v0.10, and build on iojs. (And don't send travis emails).
bcdbe8e to
e5b9fe7
Compare
|
@nfischer: Good Catch! Fixed. |
|
LGTM! |
chore: drop node v0.10 support
Drop Node
v0.10support and document.