Skip to content

travis: Mark as not using sudo and do not test 0.11#307

Merged
ariporad merged 1 commit intoshelljs:masterfrom
TimothyGu:patch-1
Jan 28, 2016
Merged

travis: Mark as not using sudo and do not test 0.11#307
ariporad merged 1 commit intoshelljs:masterfrom
TimothyGu:patch-1

Conversation

@TimothyGu
Copy link
Copy Markdown
Contributor

No description provided.

@TimothyGu
Copy link
Copy Markdown
Contributor Author

This makes Travis running on Linux significantly more consistent (all finishing within 20 seconds) and faster (with two fewer builds). Read more about sudo: false in Travis CI's documentation: https://docs.travis-ci.com/user/migrating-from-legacy/#Why-migrate-to-container-based-infrastructure%3F

@nfischer
Copy link
Copy Markdown
Member

@TimothyGu why remove v0.11? I believe we want to continue support for that if possible

@TimothyGu
Copy link
Copy Markdown
Contributor Author

0.11 is an unstable version that is not supported or updated anymore. 0.12 is fully compatible with 0.11 and as it is in maintenance mode, no breaking changes will be committed there.

@TimothyGu
Copy link
Copy Markdown
Contributor Author

And we should test 0.8 too since it is listed as supported in package.json.

@nfischer
Copy link
Copy Markdown
Member

0.12 is fully compatible with 0.11

Good point. @ariporad any thoughts? Slightly faster CI, which is nice. And it sounds like it should be safe.

For 0.8 issue, I think it's because jshint is not supported. We should probably remove 0.8 from the package.json in that case. @TimothyGu thanks for pointing that out!

@TimothyGu
Copy link
Copy Markdown
Contributor Author

Yeah we should remove 0.8 now. It's last release is over 1.5 years old and its first 3.5 yrs old.

@ariporad
Copy link
Copy Markdown
Contributor

LGTM!

ariporad added a commit that referenced this pull request Jan 28, 2016
chore(travis): switch to travis container based infrastructure and don't test `0.11`
@ariporad ariporad merged commit 86fb8d1 into shelljs:master Jan 28, 2016
@TimothyGu TimothyGu deleted the patch-1 branch January 28, 2016 04:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants