Skip to content

[MRG] MNT Only checks warnings on latest depedendencies versions in CI#12048

Merged
glemaitre merged 3 commits intoscikit-learn:masterfrom
rth:check-warning-on-last-version-only
Sep 17, 2018
Merged

[MRG] MNT Only checks warnings on latest depedendencies versions in CI#12048
glemaitre merged 3 commits intoscikit-learn:masterfrom
rth:check-warning-on-last-version-only

Conversation

@rth
Copy link
Copy Markdown
Member

@rth rth commented Sep 10, 2018 •
edited
Loading

Closes #12043

This removes error on warning from setup.cfg adds it explicitly to the CI builds that use the latest dependencies.

This is blocker would be nice to have for #12039

cc @amueller who might be opposed to this change.

@rth rth force-pushed the check-warning-on-last-version-only branch from 6cf957f to 7e2fdda Compare September 10, 2018 08:37
@rth rth mentioned this pull request Sep 10, 2018
Closed
jnothman
jnothman approved these changes Sep 12, 2018
View reviewed changes
Copy link
Copy Markdown
Member

@jnothman jnothman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also on the CRON job, perhaps?

jnothman
jnothman approved these changes Sep 12, 2018
View reviewed changes
Copy link
Copy Markdown
Member

@jnothman jnothman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also on the CRON job, perhaps?

@rth rth requested a review from glemaitre September 13, 2018 15:56
@rth
Copy link
Copy Markdown
Member Author

rth commented Sep 13, 2018

Thanks for the review ! Also added the warning check to cron..

@rth rth added this to the 0.20 milestone Sep 16, 2018
@glemaitre glemaitre merged commit 8068b97 into scikit-learn:master Sep 17, 2018
@glemaitre
Copy link
Copy Markdown
Member

glemaitre commented Sep 17, 2018

Thanks!!!

jnothman pushed a commit to jnothman/scikit-learn that referenced this pull request Sep 22, 2018
@rth @jnothman
MNT Only checks warnings on latest depedendencies versions in CI (sci…
722211a 
…kit-learn#12048)
yarikoptic added a commit to yarikoptic/scikit-learn that referenced this pull request Nov 29, 2018
@yarikoptic
Merge tag '0.20.0' into releases
ebbc522 
* tag '0.20.0': (77 commits)
  ColumnTransformer generalization to work on empty lists (scikit-learn#12084)
  add sparse_threshold to make_columns_transformer (scikit-learn#12152)
  [MRG] Convert ColumnTransformer input list to numpy array (scikit-learn#12104)
  Change version to 0.20.0
  BUG: check equality instead of identity in check_cv (scikit-learn#12155)
  [MRG] Fix FutureWarnings in logistic regression examples (scikit-learn#12114)
  [MRG] Update test_metaestimators to pass y parameter when calling score (scikit-learn#12089)
  DOC Removed duplicated doc in tree.rst (scikit-learn#11922)
  [MRG] DOC covariance doctest examples (scikit-learn#12124)
  typo and formatting fixes in 0.20 doc (scikit-learn#11963)
  DOC Replaced the deprecated early_stopping parameter with n_iter_no_change. (scikit-learn#12133)
  [MRG +1] ColumnTransformer: store evaluated function column specifier during fit (scikit-learn#12107)
  Fix typo (scikit-learn#12126)
  DOC Typo in OneHotEncoder
  DOC Update fit_transform docstring of OneHotEncoder (scikit-learn#12117)
  DOC Removing quotes from variant names. (scikit-learn#12113)
  DOC BaggingRegressor missing default value for oob_score in docstring (scikit-learn#12108)
  [MRG] MNT Re-enable PyPy CI (scikit-learn#12039)
  MNT Only checks warnings on latest depedendencies versions in CI (scikit-learn#12048)
  TST Ignore warnings in common test to avoid collection errors (scikit-learn#12093)
  ...
yarikoptic added a commit to yarikoptic/scikit-learn that referenced this pull request Nov 29, 2018
@yarikoptic
Merge branch 'releases' into dfsg
3065314 
* releases: (77 commits)
  ColumnTransformer generalization to work on empty lists (scikit-learn#12084)
  add sparse_threshold to make_columns_transformer (scikit-learn#12152)
  [MRG] Convert ColumnTransformer input list to numpy array (scikit-learn#12104)
  Change version to 0.20.0
  BUG: check equality instead of identity in check_cv (scikit-learn#12155)
  [MRG] Fix FutureWarnings in logistic regression examples (scikit-learn#12114)
  [MRG] Update test_metaestimators to pass y parameter when calling score (scikit-learn#12089)
  DOC Removed duplicated doc in tree.rst (scikit-learn#11922)
  [MRG] DOC covariance doctest examples (scikit-learn#12124)
  typo and formatting fixes in 0.20 doc (scikit-learn#11963)
  DOC Replaced the deprecated early_stopping parameter with n_iter_no_change. (scikit-learn#12133)
  [MRG +1] ColumnTransformer: store evaluated function column specifier during fit (scikit-learn#12107)
  Fix typo (scikit-learn#12126)
  DOC Typo in OneHotEncoder
  DOC Update fit_transform docstring of OneHotEncoder (scikit-learn#12117)
  DOC Removing quotes from variant names. (scikit-learn#12113)
  DOC BaggingRegressor missing default value for oob_score in docstring (scikit-learn#12108)
  [MRG] MNT Re-enable PyPy CI (scikit-learn#12039)
  MNT Only checks warnings on latest depedendencies versions in CI (scikit-learn#12048)
  TST Ignore warnings in common test to avoid collection errors (scikit-learn#12093)
  ...
yarikoptic added a commit to yarikoptic/scikit-learn that referenced this pull request Nov 29, 2018
@yarikoptic
Merge branch 'dfsg' into debian-old
fb9c55c 
* dfsg: (77 commits)
  ColumnTransformer generalization to work on empty lists (scikit-learn#12084)
  add sparse_threshold to make_columns_transformer (scikit-learn#12152)
  [MRG] Convert ColumnTransformer input list to numpy array (scikit-learn#12104)
  Change version to 0.20.0
  BUG: check equality instead of identity in check_cv (scikit-learn#12155)
  [MRG] Fix FutureWarnings in logistic regression examples (scikit-learn#12114)
  [MRG] Update test_metaestimators to pass y parameter when calling score (scikit-learn#12089)
  DOC Removed duplicated doc in tree.rst (scikit-learn#11922)
  [MRG] DOC covariance doctest examples (scikit-learn#12124)
  typo and formatting fixes in 0.20 doc (scikit-learn#11963)
  DOC Replaced the deprecated early_stopping parameter with n_iter_no_change. (scikit-learn#12133)
  [MRG +1] ColumnTransformer: store evaluated function column specifier during fit (scikit-learn#12107)
  Fix typo (scikit-learn#12126)
  DOC Typo in OneHotEncoder
  DOC Update fit_transform docstring of OneHotEncoder (scikit-learn#12117)
  DOC Removing quotes from variant names. (scikit-learn#12113)
  DOC BaggingRegressor missing default value for oob_score in docstring (scikit-learn#12108)
  [MRG] MNT Re-enable PyPy CI (scikit-learn#12039)
  MNT Only checks warnings on latest depedendencies versions in CI (scikit-learn#12048)
  TST Ignore warnings in common test to avoid collection errors (scikit-learn#12093)
  ...
@rth rth deleted the check-warning-on-last-version-only branch March 18, 2019 20:38
@rth rth mentioned this pull request Mar 6, 2020
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jnothman jnothman jnothman approved these changes

@glemaitre glemaitre Awaiting requested review from glemaitre

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

0.20

Development

Successfully merging this pull request may close these issues.

3 participants

@rth @glemaitre @jnothman