Merged
Conversation
tv_denoise passes keyword arguments `eps` and `weight` as positional arguments, but the order in _tv_denoise_2d was switched.
Original test only checked that tv_denoise reduced the total variation. This change makes sure that the reduction is significant.
stefanv
pushed a commit
that referenced
this pull request
Dec 1, 2011
Convert contour finding code to Cython and add an example.
tonysyu
referenced
this pull request
in tonysyu/scikit-image
Dec 20, 2011
Merge Tony's improvements on segmentation tutorial
stefanv
pushed a commit
that referenced
this pull request
Aug 13, 2012
Refactor geometric transforms.
tonysyu
pushed a commit
that referenced
this pull request
Dec 18, 2012
FIX quickshift nosetest with different xyz color conversion
thouis
added a commit
that referenced
this pull request
Mar 28, 2013
Add test case for rank filter fix
ahojnnes
pushed a commit
that referenced
this pull request
Apr 3, 2013
Make `exclude_borders` option in peak_local_max nD
riaanvddool
pushed a commit
to riaanvddool/scikits-image
that referenced
this pull request
Sep 26, 2013
Refactor block process.
stefanv
pushed a commit
that referenced
this pull request
Nov 21, 2013
Format color conversion docstrings.
stefanv
pushed a commit
that referenced
this pull request
Apr 16, 2014
Refactor IPython notebook export
Closed
3 tasks
8 tasks
GenevieveBuckley
pushed a commit
to GenevieveBuckley/scikit-image
that referenced
this pull request
Nov 14, 2018
update from upstream
13 tasks
emmanuelle
pushed a commit
that referenced
this pull request
Jan 8, 2020
enable anistropic window shape
hmaarrfk
added a commit
that referenced
this pull request
Feb 17, 2020
* Implemeted multichannel support for denoise_tv_bregman (#1) Compare issue #4427 in upstream * Implemented unittest * Refactored code * wrapped around long lines * Indention, empty line and whitespace lint issues * Update skimage/restoration/_denoise.py Co-Authored-By: Mark Harfouche <mark.harfouche@gmail.com> * Update skimage/restoration/_denoise.py Co-Authored-By: Mark Harfouche <mark.harfouche@gmail.com> * For the multichannel flag only 2D images + channel dimension is supported * over-indented * Update skimage/restoration/_denoise.py Co-Authored-By: Mark Harfouche <mark.harfouche@gmail.com> * Update skimage/restoration/_denoise.py * Apply suggestions from code review Allocate channel output array prior to loop. * Apply suggestions from code review Only allocate `channel_out` if `multichannel` is `True` * Added check for multichannel bregman Co-authored-by: Mark Harfouche <mark.harfouche@gmail.com>
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The order of arguments passed from tv_denoise to _tv_denoise_2d is incorrect. Fix order of arguments and make test more strict. Switch order of eps and weight keyword arguments.