Multichannel support for denoise_tv_bregman (#4427)#4446
Merged
hmaarrfk merged 12 commits intoscikit-image:masterfrom Feb 17, 2020
Merged
Multichannel support for denoise_tv_bregman (#4427)#4446hmaarrfk merged 12 commits intoscikit-image:masterfrom
hmaarrfk merged 12 commits intoscikit-image:masterfrom
Conversation
Compare issue #4427 in upstream * Implemented unittest * Refactored code
|
Hello @erjel! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:
Comment last updated at 2020-02-17 20:40:44 UTC |
hmaarrfk
reviewed
Feb 15, 2020
hmaarrfk
reviewed
Feb 15, 2020
hmaarrfk
reviewed
Feb 15, 2020
hmaarrfk
reviewed
Feb 15, 2020
hmaarrfk
reviewed
Feb 15, 2020
Co-Authored-By: Mark Harfouche <mark.harfouche@gmail.com>
Co-Authored-By: Mark Harfouche <mark.harfouche@gmail.com>
hmaarrfk
reviewed
Feb 15, 2020
Co-Authored-By: Mark Harfouche <mark.harfouche@gmail.com>
hmaarrfk
reviewed
Feb 15, 2020
hmaarrfk
reviewed
Feb 15, 2020
erjel
commented
Feb 15, 2020
Allocate channel output array prior to loop.
hmaarrfk
approved these changes
Feb 15, 2020
Member
hmaarrfk
left a comment
There was a problem hiding this comment.
Approved pending the last comment.
erjel
commented
Feb 16, 2020
Only allocate `channel_out` if `multichannel` is `True`
Member
|
Sorry ahjnnes. I was just trying to add a label. |
rfezzani
reviewed
Feb 17, 2020
| denoised0 = restoration.denoise_tv_bregman(img_astro[..., 0], weight=60.0) | ||
| denoised = restoration.denoise_tv_bregman(img_astro, weight=60.0, | ||
| multichannel=True) | ||
|
|
Member
There was a problem hiding this comment.
May be can you check that assert_equal(denoised0, denoised[..., 0])?
Contributor
Author
There was a problem hiding this comment.
Sure. Thank you for pointing this out. I must have missed it.
rfezzani
approved these changes
Feb 17, 2020
Member
|
Thank you for your work, @erjel! We appreciate it. :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Proposal for closing issue #4427
Added
multichannelparameter todenoise_tv_bregmanfunction.Checklist
Gallery example in(new features only)./doc/examplesBenchmark in./benchmarks, if your changes aren't covered by anexisting benchmark
For reviewers
later.
__init__.py.doc/release/release_dev.rst.@meeseeksdev backport to v0.14.x