Skip to content

Add contrast stretching.#1

Merged
tonysyu merged 2 commits intotonysyu:rescale-intensityfrom
stefanv:tony_rescale_intensity
Feb 4, 2012
Merged

Add contrast stretching.#1
tonysyu merged 2 commits intotonysyu:rescale-intensityfrom
stefanv:tony_rescale_intensity

Conversation

@stefanv
Copy link
Copy Markdown

@stefanv stefanv commented Feb 3, 2012

No description provided.

@tonysyu
Copy link
Copy Markdown
Owner

tonysyu commented Feb 3, 2012

I really like the example! I'm not sure about the use of plt.subplots, though. I used it in a previous PR, and someone suggested that I use the older style for backward compatibility. Personally, I'm fine with it, but we should probably talk about version requirements of dependencies on the mailing list. For example, numpy version came up in the dtype._convert pull request (b/c of np.promote_types).

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should these be p2 and p98?

@stefanv
Copy link
Copy Markdown
Author

stefanv commented Feb 4, 2012

Thanks, fixed!

In my mind, subplots alone is worth the matplotlib 1.0 dependency. If people don't like that, we may just want to copy subplots over into skimage for now. It makes the creation of programmatic plots so much neater!

@tonysyu
Copy link
Copy Markdown
Owner

tonysyu commented Feb 4, 2012

Agreed: subplots is great. Thanks for the PR. I'm merging into my branch, but I suggest we wait a day or so before merging into skimage to see if anyone else has comments about dependency versions.

@tonysyu tonysyu closed this Feb 4, 2012
tonysyu added a commit that referenced this pull request Feb 4, 2012
@tonysyu tonysyu merged commit b4eb6ee into tonysyu:rescale-intensity Feb 4, 2012
tonysyu pushed a commit that referenced this pull request Aug 23, 2012
Refactor geometric transforms.
tonysyu pushed a commit that referenced this pull request Aug 23, 2012
tonysyu pushed a commit that referenced this pull request Nov 15, 2012
tonysyu pushed a commit that referenced this pull request Jan 17, 2013
FIX quickshift nosetest with different xyz color conversion
tonysyu pushed a commit that referenced this pull request Jan 17, 2013
tonysyu pushed a commit that referenced this pull request Mar 30, 2013
Add test case for rank filter fix
tonysyu pushed a commit that referenced this pull request Apr 10, 2013
Make `exclude_borders` option in peak_local_max nD
tonysyu pushed a commit that referenced this pull request Jun 29, 2013
tonysyu pushed a commit that referenced this pull request Dec 6, 2013
Format color conversion docstrings.
tonysyu pushed a commit that referenced this pull request Jun 18, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants