Upgrade the 2.12 scala-compiler's dependency on scala-xml to 2.1.0 (was 1.0.6)#10108
Merged
SethTisue merged 1 commit intoscala:2.12.xfrom Aug 24, 2022
Merged
Upgrade the 2.12 scala-compiler's dependency on scala-xml to 2.1.0 (was 1.0.6)#10108SethTisue merged 1 commit intoscala:2.12.xfrom
SethTisue merged 1 commit intoscala:2.12.xfrom
Conversation
Member
Author
|
I temporarily added a commit (70d7e00) to demonstrate that even with the new code, Scaladoc generation can still operate even if someone overrides the dependency back to 1.0.6. The extra commit has now been removed again. |
dongjoon-hyun
pushed a commit
to apache/spark
that referenced
this pull request
Sep 17, 2022
### What changes were proposed in this pull request? This PR aims to upgrade Scala to 2.12.17 - https://www.scala-lang.org/news/2.12.17 ### Why are the changes needed? The main [change](https://github.com/scala/scala/pulls?q=is%3Apr+sort%3Aupdated-desc+milestone%3A2.12.17+is%3Amerged+label%3Arelease-notes) fo this version as follows: - scala/scala#10109 - scala/scala#10075 - scala/scala#10108 - scala/scala#10045 - scala/scala#10063 - scala/scala#10042 - scala/scala#10040 - scala/scala#10095 ### Does this PR introduce _any_ user-facing change? Yes, this is a Scala version change. ### How was this patch tested? Existing Test Closes #37892 from LuciferYang/SPARK-40436. Authored-by: yangjie01 <yangjie01@baidu.com> Signed-off-by: Dongjoon Hyun <dongjoon@apache.org>
LuciferYang
added a commit
to LuciferYang/spark
that referenced
this pull request
Sep 20, 2022
### What changes were proposed in this pull request? This PR aims to upgrade Scala to 2.12.17 - https://www.scala-lang.org/news/2.12.17 ### Why are the changes needed? The main [change](https://github.com/scala/scala/pulls?q=is%3Apr+sort%3Aupdated-desc+milestone%3A2.12.17+is%3Amerged+label%3Arelease-notes) fo this version as follows: - scala/scala#10109 - scala/scala#10075 - scala/scala#10108 - scala/scala#10045 - scala/scala#10063 - scala/scala#10042 - scala/scala#10040 - scala/scala#10095 ### Does this PR introduce _any_ user-facing change? Yes, this is a Scala version change. ### How was this patch tested? Existing Test Closes apache#37892 from LuciferYang/SPARK-40436. Authored-by: yangjie01 <yangjie01@baidu.com> Signed-off-by: Dongjoon Hyun <dongjoon@apache.org>
This was referenced Sep 26, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes scala/bug#12632
Scala 2.13 doesn't depend on scala-xml at all, so this is a 2.12-specific change.
This upgrade might affect anyone who has scala-compiler in their dependencies. As discussed on the ticket, it is likeliest to affect the sbt 1.x plugin ecosystem.
Note that despite the major version number bump, scala-xml 1.x and 2.x are mostly binary compatible and mostly source compatible.
There is some more detailed discussion on the ticket of the implication of this change and the compatibility testing we did before going forward with it. If this change results in a version conflict in your codebase, in most scenarios it won't matter whether you resolve the conflict in favor of 1.x or 2.x. In particular, we believe scala-compiler won't care if you choose to stay on scala-xml 1.x.
Regardless, we encourage users to move to scala-xml 2.x if you can. In particular, we encourage the sbt plugin ecosystem to upgrade.