Tooling support: Add a tree attachment to mark auto-applications#10063
Merged
SethTisue merged 1 commit intoscala:2.12.xfrom Jun 30, 2022
Merged
Tooling support: Add a tree attachment to mark auto-applications#10063SethTisue merged 1 commit intoscala:2.12.xfrom
SethTisue merged 1 commit intoscala:2.12.xfrom
Conversation
a340378 to
a7433f8
Compare
SethTisue
approved these changes
Jun 30, 2022
Member
SethTisue
left a comment
There was a problem hiding this comment.
Changes look fine, but can you briefly indicate what the motivation is? To help tooling authors? Compiler plugin authors?
dwijnand
approved these changes
Jun 30, 2022
Member
|
I guess this is just an addendum to #10042 ? |
Member
Author
|
Yeah, it's useful metadata for tooling that uses the compiler ASTs, it's very hard to recover this information otherwise. |
dongjoon-hyun
pushed a commit
to apache/spark
that referenced
this pull request
Sep 17, 2022
### What changes were proposed in this pull request? This PR aims to upgrade Scala to 2.12.17 - https://www.scala-lang.org/news/2.12.17 ### Why are the changes needed? The main [change](https://github.com/scala/scala/pulls?q=is%3Apr+sort%3Aupdated-desc+milestone%3A2.12.17+is%3Amerged+label%3Arelease-notes) fo this version as follows: - scala/scala#10109 - scala/scala#10075 - scala/scala#10108 - scala/scala#10045 - scala/scala#10063 - scala/scala#10042 - scala/scala#10040 - scala/scala#10095 ### Does this PR introduce _any_ user-facing change? Yes, this is a Scala version change. ### How was this patch tested? Existing Test Closes #37892 from LuciferYang/SPARK-40436. Authored-by: yangjie01 <yangjie01@baidu.com> Signed-off-by: Dongjoon Hyun <dongjoon@apache.org>
LuciferYang
added a commit
to LuciferYang/spark
that referenced
this pull request
Sep 20, 2022
### What changes were proposed in this pull request? This PR aims to upgrade Scala to 2.12.17 - https://www.scala-lang.org/news/2.12.17 ### Why are the changes needed? The main [change](https://github.com/scala/scala/pulls?q=is%3Apr+sort%3Aupdated-desc+milestone%3A2.12.17+is%3Amerged+label%3Arelease-notes) fo this version as follows: - scala/scala#10109 - scala/scala#10075 - scala/scala#10108 - scala/scala#10045 - scala/scala#10063 - scala/scala#10042 - scala/scala#10040 - scala/scala#10095 ### Does this PR introduce _any_ user-facing change? Yes, this is a Scala version change. ### How was this patch tested? Existing Test Closes apache#37892 from LuciferYang/SPARK-40436. Authored-by: yangjie01 <yangjie01@baidu.com> Signed-off-by: Dongjoon Hyun <dongjoon@apache.org>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Mark uses of auto-application with a tree attachment. This can be useful for tooling that builds on the compiler / scala reflection.
Sequel to #10063.