Tooling support: Attachments for infix Apply and postfix Select#10042
Merged
lrytz merged 1 commit intoscala:2.12.xfrom Jun 8, 2022
Merged
Tooling support: Attachments for infix Apply and postfix Select#10042lrytz merged 1 commit intoscala:2.12.xfrom
lrytz merged 1 commit intoscala:2.12.xfrom
Conversation
Mark infix applications and postfix selections with a tree attachment. This can be useful for tooling that builds on the compiler / scala reflection.
lrytz
commented
Jun 3, 2022
| case class InjectDerivedValue(arg: Tree) | ||
| extends SymTree with TermTree | ||
|
|
||
| class PostfixSelect(qual: Tree, name: Name) extends Select(qual, name) |
Member
Author
There was a problem hiding this comment.
I searched GitHub for PostfixSelect, found this one: https://github.com/scalameta/trees/blob/fb4cbb515b9a4b65fd679f1e9c13860a7038b748/semanticdb/scalac/library/src/main/scala-2.12.7/scala/meta/internal/semanticdb/scalac/SemanticdbAnalyzer.scala#L539
Contributor
There was a problem hiding this comment.
Looks like it was inlined into scalameta/scalameta and only used for versions prior to 2.12.8, which is no longer supported. So we should be good I think.
retronym
approved these changes
Jun 7, 2022
Member
|
should we release-note this? (might other tooling maintainers be interested, besides the one you're already in touch with?) |
Member
Author
|
OK with me, there might be projects out there |
Merged
dongjoon-hyun
pushed a commit
to apache/spark
that referenced
this pull request
Sep 17, 2022
### What changes were proposed in this pull request? This PR aims to upgrade Scala to 2.12.17 - https://www.scala-lang.org/news/2.12.17 ### Why are the changes needed? The main [change](https://github.com/scala/scala/pulls?q=is%3Apr+sort%3Aupdated-desc+milestone%3A2.12.17+is%3Amerged+label%3Arelease-notes) fo this version as follows: - scala/scala#10109 - scala/scala#10075 - scala/scala#10108 - scala/scala#10045 - scala/scala#10063 - scala/scala#10042 - scala/scala#10040 - scala/scala#10095 ### Does this PR introduce _any_ user-facing change? Yes, this is a Scala version change. ### How was this patch tested? Existing Test Closes #37892 from LuciferYang/SPARK-40436. Authored-by: yangjie01 <yangjie01@baidu.com> Signed-off-by: Dongjoon Hyun <dongjoon@apache.org>
LuciferYang
added a commit
to LuciferYang/spark
that referenced
this pull request
Sep 20, 2022
### What changes were proposed in this pull request? This PR aims to upgrade Scala to 2.12.17 - https://www.scala-lang.org/news/2.12.17 ### Why are the changes needed? The main [change](https://github.com/scala/scala/pulls?q=is%3Apr+sort%3Aupdated-desc+milestone%3A2.12.17+is%3Amerged+label%3Arelease-notes) fo this version as follows: - scala/scala#10109 - scala/scala#10075 - scala/scala#10108 - scala/scala#10045 - scala/scala#10063 - scala/scala#10042 - scala/scala#10040 - scala/scala#10095 ### Does this PR introduce _any_ user-facing change? Yes, this is a Scala version change. ### How was this patch tested? Existing Test Closes apache#37892 from LuciferYang/SPARK-40436. Authored-by: yangjie01 <yangjie01@baidu.com> Signed-off-by: Dongjoon Hyun <dongjoon@apache.org>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Mark infix applications and postfix selections with a tree attachment. This can be useful for tooling that builds on the compiler / scala reflection.
A followup, #10063, does the same thing for auto-application.