[0.13.10] Fix bincompat issue introduced in #2268#2342
Conversation
There was a problem hiding this comment.
Do you want to restore the semantics that were changed here as well?
9fbbaab?diff=unified#diff-dd0ad8518ad4dee1e8ab8f4f1d69cbe4R61
There was a problem hiding this comment.
I think the semantics for the def classLocationFile(cl: Class[_]): File remain the same.
There was a problem hiding this comment.
Looks to me like it used to fallback to using the system classloader (via old classLocation(cl: Class[_]): URL) and now it doesn't.
There was a problem hiding this comment.
You're right. Do you want to take over porting the fixing on to this branch?
There was a problem hiding this comment.
I'm prepping to clean re-install my laptop so I can't ATM, sorry.
I will if this is still like this when I'm setup again (maybe this weekend maybe in 10 days..)
|
Ah I now understand what you meant in #2321 now... Sorry for dropping the ball there and picking up the slack. Thanks, 1 comment. |
|
Excellent, thank you. LGTM pending Travis. |
[0.13.10] Fix bincompat issue introduced in #2268
Continuation of #2321
Ref #2268
/review @dwijnand, @Duhemm, @jsuereth