Fix support for parsing of classes located in runtime jars#2268
Merged
Fix support for parsing of classes located in runtime jars#2268
Conversation
|
Can one of the admins verify this patch? |
Member
|
Fixes #2263? |
Member
|
Coincidently I haven't merged months old sbt/io/pull/13 yet. Could you update that PR too? |
eed3si9n
added a commit
that referenced
this pull request
Nov 11, 2015
…classes Fix support for parsing of classes located in runtime jars
Member
There was a problem hiding this comment.
@eed3si9n Do we want to do something about this binary compatibility breakage before cutting a 0.13.10 release?
Member
There was a problem hiding this comment.
Yes. Could you send a PR or issue against 0.13 to fix this?
Member
|
Is this a fix to an improvement for which we have notes or is it a fix that requires its own notes? |
Member
Member
|
Cool thanks. |
Member
|
Also, this hasn't been forward-ported to 1.0, which I realise is a little hard as it's touching files in different modules.. |
eed3si9n
added a commit
that referenced
this pull request
Dec 30, 2015
eed3si9n
added a commit
that referenced
this pull request
Dec 30, 2015
[0.13.10] Fix bincompat issue introduced in #2268
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.