Fix bincompat from change in #2268#2321
Closed
Conversation
|
Can one of the admins verify this patch? |
Member
Author
|
Travis finally passed. Ready for review. |
Member
|
I think you're missing the semantic difference introduced in 9fbbaab. The old one returns directory while the new one returns the actual *.class location IIUC. |
Member
Author
|
Which change(s) in particular? I'm a bit lost. My intent here is just the restore binary compatibility. Any semantic difference introduced in that commit was accepted and is already in 0.13. Do you want to revert that and restore the previous semantics? |
Member
|
See I think we need to add both the implementation. /cc @stuhood |
Member
|
Closing this in favor of #2342 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.