Update scala to version 2.10.5#1980
Conversation
|
Can one of the admins verify this patch? |
|
Can you run scripted tests locally? |
|
The last Scala version bump happened on #1212. This didn't require change to scripted as far as I can tell. |
|
I can rollback two last commits and you will see the result. |
|
Failed test - problem with bintray ... My local result: |
There was a problem hiding this comment.
If this is required, we should fix the build script instead of putting it in .travis.yml so all required JARs are published locally before the scripted tests.
There was a problem hiding this comment.
It will be required only - when 0.13.9 will be published. After it the .travis script can be restored.
Please checkout the code beaf39a and run the tests. You will receive: errors, see all the builds in: https://travis-ci.org/sbt/sbt/builds/54919087:
....
About to run tests:
* actions/*
java.lang.NoSuchMethodException: sbt.test.ScriptedTests$.run(java.io.File, boolean, [Ljava.lang.String;, java.io.File, [Ljava.lang.String;, scala.Function1)
at java.lang.Class.getMethod(Class.java:1667)
at Scripted$.doScripted(Scripted.scala:66)
at $0e28670edea040be68f9$$anonfun$scriptedTask$2$$anonfun$apply$2$$anonfun$apply$3.apply(build.sbt:474)
at $0e28670edea040be68f9$$anonfun$scriptedTask$2$$anonfun$apply$2$$anonfun$apply$3.apply(build.sbt:471)
at scala.Function1$$anonfun$compose$1.apply(Function1.scala:47)
...
I guess it is problem with classloader. Mentioned in stack method exist.
As the solution the new process should be run - by scala 2.10.5 - and then all is run by the same classloader.
There was a problem hiding this comment.
Ah, I ran into this. The way we use scripted is a bit gunky now. We actually no longer have it isolated, so we need to fix it.
|
@eed3si9n We should figure out how to merge this before 0.13.9 |
|
Ok, so we bumped to 2.11.6, what should we do with this PR? |
|
You can jest close without merging. 2.11.6 contains the same correction |
|
@jsuereth we bumped what to what? |
To pass File => Unit callback across the classloader boundary I am encoding it as a java.util.List[File] by overriding method. This was needed since Java didn't allow me to cast from one classloader to the other.
|
Closing this in favor of #2068 |
To pass File => Unit callback across the classloader boundary I am encoding it as a java.util.List[File] by overriding method. This was needed since Java didn't allow me to cast from one classloader to the other.
To pass File => Unit callback across the classloader boundary I am encoding it as a java.util.List[File] by overriding method. This was needed since Java didn't allow me to cast from one classloader to the other.
See #1666, scala/scala#4186 solved problem with xml groups.