Bumping up Scala version to 2.10.5/2.11.6. Fixes #1666, Ref #1980#2068
Merged
Bumping up Scala version to 2.10.5/2.11.6. Fixes #1666, Ref #1980#2068
Conversation
To pass File => Unit callback across the classloader boundary I am encoding it as a java.util.List[File] by overriding method. This was needed since Java didn't allow me to cast from one classloader to the other.
Member
Author
There was a problem hiding this comment.
I can add shims around to keep bincompat, but this module should be used only by sbt itself, so I don't think it matters.
Member
|
The change looks good. Just want to make sure the up-scaled interface is ABI compatible. I think it is. In practice, given how scripted is used, I think it doesn't matter as well (scripted is usually versioned by the sbt version). |
Member
Author
|
Yea. Note I didn't touch the scripted base or scripted plugin. (They may actually encounter similar issue as I have) |
Member
|
LGTM. Can the crazy use of java.util.List be removed post 0.13.9 when sbt's build moves to 0.13.9? |
Member
Author
|
We need to add |
eed3si9n
added a commit
that referenced
this pull request
Jul 10, 2015
adriaanm
added a commit
to adriaanm/sbt
that referenced
this pull request
Dec 21, 2015
adriaanm
added a commit
to adriaanm/sbt
that referenced
this pull request
Dec 21, 2015
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1666, Subsumes #1980
To pass
File => Unitcallback across the classloader boundaryI am encoding it as a
java.util.List[File]by overridingadd(x: File)method.This was needed since Java didn't allow me to cast from one classloader to the other.
/review @jsuereth, @dwijnand