Skip to content

SI-9027 Backport xml parser fix#4186

Merged
gkossakowski merged 1 commit intoscala:2.10.xfrom
som-snytt:issue/9027-backport
Dec 8, 2014
Merged

SI-9027 Backport xml parser fix#4186
gkossakowski merged 1 commit intoscala:2.10.xfrom
som-snytt:issue/9027-backport

Conversation

@som-snytt
Copy link
Contributor

Fingers crossed, I have no local java 6 here to test.

No test because no q"" on 2.10.

This is backport of #4185.

Fingers crossed, I have no local java 6 here to test.

No test because no q"" on 2.10.
@scala-jenkins scala-jenkins added this to the 2.10.5 milestone Dec 4, 2014
@som-snytt
Copy link
Contributor Author

The test failure is whatever is in IDE's head at the moment.

FTR, I did download java 6, thanks to Ubuntu I didn't have to sign in to Oracle's vault, and ran the build in the background.

@gkossakowski
Copy link
Contributor

PLS REBUILD ALL

@gkossakowski
Copy link
Contributor

Let's give IDE validation another try.

@scala-jenkins
Copy link

(kitty-note-to-self: ignore 65788334)
🐱 Roger! Rebuilding pr-scala for 736293a. 🚨

@gkossakowski
Copy link
Contributor

The failure is persistent. I pinged IDE team to look at it. I think we can merge it but I'll ask @adriaanm for second pair of eyeballs.

@adriaanm
Copy link
Contributor

adriaanm commented Dec 5, 2014

LGTM

@som-snytt
Copy link
Contributor Author

Technically, a third pair of eyeballs.

I'm such a tool, I'm uncomfortable if I can't trust my tool to tell me if something is fishy.

gkossakowski added a commit that referenced this pull request Dec 8, 2014
@gkossakowski gkossakowski merged commit 3115f88 into scala:2.10.x Dec 8, 2014
@ajozwik
Copy link

ajozwik commented Dec 8, 2014

When will the 2.10.5 be delivered?

@adriaanm
Copy link
Contributor

adriaanm commented Dec 8, 2014

2.10.5 (the last 2.10.x release) will be out by the end of Q1 of 2015, after 2.11.5 and 2.12.0-M1 are out. (We try to keep the overview at https://github.com/scala/scala/milestones up to date.)

@ajozwik
Copy link

ajozwik commented Dec 8, 2014

sbt uses 2.10.4 - and it needs xml parser fix. Thank you for quick response.
See sbt/sbt#1765

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants