SI-9027 Parser no longer consumes space after multi XML elements#4185
Merged
gkossakowski merged 1 commit intoscala:2.11.xfrom Dec 4, 2014
Merged
SI-9027 Parser no longer consumes space after multi XML elements#4185gkossakowski merged 1 commit intoscala:2.11.xfrom
gkossakowski merged 1 commit intoscala:2.11.xfrom
Conversation
Contributor
|
Missing JUnit test? |
Contributor
Author
|
I must emulate the clever test at 8d175b9 |
Once the parser starts looking for more <elements>, it should still lookahead speculatively, leaving any remaining whitespace, including newlines, after the last element.
Member
|
PLS REBUILD/pr-scala@db8d5476537902760d33d29839afd813ff369ac8 |
Member
|
LGTM! |
|
(kitty-note-to-self: ignore 65590215) |
gkossakowski
added a commit
that referenced
this pull request
Dec 4, 2014
SI-9027 Parser no longer consumes space after multi XML elements
Contributor
|
This problem affects sbt (sbt/sbt#1666, sbt/sbt#1738) and sbt is still using Scala 2.10. Would it be possible to have it backported? |
Contributor
Author
|
Sure. A quick test shows it introduces a mima bc error. Maybe I'll just start a PR and someone can tell me about whitelisting. |
|
+1 |
som-snytt
added a commit
to som-snytt/dotty
that referenced
this pull request
Feb 6, 2020
Forward port of scala/scala#4185
som-snytt
added a commit
to som-snytt/dotty
that referenced
this pull request
Feb 6, 2020
Forward port of scala/scala#4185
gabro
pushed a commit
to gabro/dotty
that referenced
this pull request
Feb 11, 2020
Forward port of scala/scala#4185
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Once the parser starts looking for more , it should
still lookahead speculatively, leaving any remaining whitespace,
including newlines, after the last element.